Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Compare coverage using specific commit shas #699

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

aborgna-q
Copy link
Collaborator

We store the last commit we notified about, so the notifications actually cover the period we care about.

Copy link

codecov bot commented Nov 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c261bea) 83.93% compared to head (d48eefc) 83.94%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #699   +/-   ##
=======================================
  Coverage   83.93%   83.94%           
=======================================
  Files          66       66           
  Lines       12706    12706           
  Branches    12706    12706           
=======================================
+ Hits        10665    10666    +1     
  Misses       1285     1285           
+ Partials      756      755    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@cqc-alec cqc-alec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@aborgna-q aborgna-q added this pull request to the merge queue Nov 16, 2023
Merged via the queue into main with commit e7473f2 Nov 16, 2023
10 checks passed
@aborgna-q aborgna-q deleted the ci/notify-actual-coverage-values branch November 16, 2023 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants