Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: Make Either::Right the "success" case #1489

Merged
merged 5 commits into from
Aug 30, 2024

Use `comma_sep_str`

1488d69
Select commit
Loading
Failed to load commit list.
Merged

refactor!: Make Either::Right the "success" case #1489

Use `comma_sep_str`
1488d69
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 30, 2024 in 1s

87.27% (+0.02%) compared to aca403a

View this Pull Request on Codecov

87.27% (+0.02%) compared to aca403a

Details

Codecov Report

Attention: Patch coverage is 96.93878% with 3 lines in your changes missing coverage. Please review.

Project coverage is 87.27%. Comparing base (aca403a) to head (1488d69).

Files with missing lines Patch % Lines
...td_extensions/arithmetic/conversions/const_fold.rs 25.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1489      +/-   ##
==========================================
+ Coverage   87.24%   87.27%   +0.02%     
==========================================
  Files         125      125              
  Lines       21352    21331      -21     
  Branches    18380    18359      -21     
==========================================
- Hits        18628    18616      -12     
+ Misses       1950     1948       -2     
+ Partials      774      767       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.