Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add failing test case for #1315 #1316

Merged
merged 4 commits into from
Jul 16, 2024
Merged

test: Add failing test case for #1315 #1316

merged 4 commits into from
Jul 16, 2024

Conversation

doug-q
Copy link
Collaborator

@doug-q doug-q commented Jul 16, 2024

No description provided.

@doug-q doug-q requested a review from a team as a code owner July 16, 2024 13:24
@doug-q doug-q requested a review from cqc-alec July 16, 2024 13:24
Copy link
Collaborator

@cqc-alec cqc-alec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest adding reference to issue in comment.

hugr-core/src/ops/custom.rs Outdated Show resolved Hide resolved
Copy link

codecov bot commented Jul 16, 2024

Codecov Report

Attention: Patch coverage is 93.75000% with 1 line in your changes missing coverage. Please review.

Project coverage is 87.33%. Comparing base (a6a9b74) to head (d03d990).

Files Patch % Lines
hugr-core/src/ops/custom.rs 93.75% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1316      +/-   ##
==========================================
+ Coverage   87.27%   87.33%   +0.06%     
==========================================
  Files         107      107              
  Lines       19626    19642      +16     
  Branches    17362    17378      +16     
==========================================
+ Hits        17129    17155      +26     
+ Misses       1714     1705       -9     
+ Partials      783      782       -1     
Flag Coverage Δ
rust 86.80% <93.75%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

doug-q and others added 3 commits July 16, 2024 14:35
Co-authored-by: Alec Edgington <54802828+cqc-alec@users.noreply.github.com>
@doug-q doug-q enabled auto-merge July 16, 2024 13:42
@doug-q doug-q added this pull request to the merge queue Jul 16, 2024
Merged via the queue into main with commit 6f8dac2 Jul 16, 2024
20 checks passed
@doug-q doug-q deleted the doug/test-1315 branch July 16, 2024 13:49
@hugrbot hugrbot mentioned this pull request Jul 16, 2024
github-merge-queue bot pushed a commit that referenced this pull request Jul 19, 2024
## 🤖 New release
* `hugr`: 0.8.0 -> 0.9.0
* `hugr-core`: 0.5.0 -> 0.6.0
* `hugr-passes`: 0.5.0 -> 0.6.0
* `hugr-cli`: 0.1.4 -> 0.2.0

<details><summary><i><b>Changelog</b></i></summary><p>

## `hugr`
<blockquote>

## 0.9.0 (2024-07-19)

### Bug Fixes

- Add op's extension to signature check in `resolve_opaque_op`
([#1317](#1317))
- Panic on `SimpleReplace` with multiports
([#1324](#1324))

### Refactor

- [**breaking**] Separate Signature from FuncValueType by parametrizing
Type(/Row)/etc. ([#1138](#1138))

### Testing

- Verify order edges ([#1293](#1293))
- Add failing test case for
[#1315](#1315)
([#1316](#1316))
</blockquote>

## `hugr-core`
<blockquote>

## 0.6.0 (2024-07-19)

### Bug Fixes

- Add op's extension to signature check in `resolve_opaque_op`
([#1317](#1317))
- Panic on `SimpleReplace` with multiports
([#1324](#1324))

### Refactor

- [**breaking**] Separate Signature from FuncValueType by parametrizing
Type(/Row)/etc. ([#1138](#1138))

### Testing

- Verify order edges ([#1293](#1293))
- Add failing test case for
[#1315](#1315)
([#1316](#1316))
</blockquote>

## `hugr-passes`
<blockquote>

## 0.6.0 (2024-07-19)

### Refactor

- [**breaking**] Separate Signature from FuncValueType by parametrizing
Type(/Row)/etc. ([#1138](#1138))
</blockquote>

## `hugr-cli`
<blockquote>

## 0.2.0 (2024-07-19)

### Refactor

- [**breaking**] Separate Signature from FuncValueType by parametrizing
Type(/Row)/etc. ([#1138](#1138))
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/MarcoIeni/release-plz/).

---------

Co-authored-by: Douglas Wilson <douglas.wilson@quantinuum.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants