docs: Add release instructions to DEVELOPMENT.md #1070
Conversation
| pre-release). | ||
|
|
||
| To override the version getting released, you must merge a PR to `main` containing | ||
| `Release-As: 0.1.0` in the description. |
There was a problem hiding this comment.
What happens if you have two python packages? How do you override per-package? I had a quick look but can't see.
There was a problem hiding this comment.
Where did the version bump in #1040 come from? Did you push directly to the release branch? Perhaps we should stick with that method, I am concerned that github will be annoying about merging empty commits.
There was a problem hiding this comment.
Tried to look a bit into release-please's code, but this in not really clear.
-
The python release type. Auto-bumps the version according to the changes (e.g. patch release for
fix:, minor/major release depending on breaking changes. This didn't quite work with the last (breaking) release, it seems it bumped0.2.0a1to0.2.1as a breaking release. It's incorrect but harmless. -
The docs about
Release-asjust say to put in on a commit. My guess from what I gather is that that affects commits with relevant changes to the repo (commits that do not modify the subproject are ignored), so we should add the flag to a relevant commit only.
|
My understanding is that I should not merge #1040, because I'm not in the release team. What happens if I do merge it? How do we recover? |
The PR requires an approval from the CODEOWNERS, so you won't be able to merge it before that. |
Co-authored-by: doug-q <141026920+doug-q@users.noreply.github.com>
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
No description provided.