Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We have two struct ExtensionValue #989

Closed
doug-q opened this issue May 2, 2024 · 3 comments · Fixed by #1036
Closed

We have two struct ExtensionValue #989

doug-q opened this issue May 2, 2024 · 3 comments · Fixed by #1036

Comments

@doug-q
Copy link
Collaborator

doug-q commented May 2, 2024

one in hugr::ops::constant, one in hugr::extension.

hugr::extension::ExtensionValue describes a static value provided by and Extension;

hugr::ops::constant::ExtensionValue is an opaque Box<dyn CustomConst> used in the Value::Extension variant.

I propose we rename one, although I don't have a good idea for how.

@cqc-alec
Copy link
Collaborator

I suggest renaming hugr::ops::constant::ExtensionValue ... maybe to something like ExtensionConst?

@doug-q
Copy link
Collaborator Author

doug-q commented May 14, 2024

what about CustomValue or OpaqueValue? Probably we would name trait CustomConst as trait CustomValue today right?

@cqc-alec
Copy link
Collaborator

Yeah either of those sounds OK to me.

github-merge-queue bot pushed a commit that referenced this issue May 14, 2024
…lue` (#1036)

Fixes #989.

The name `ExtensionValue` clashed with
`crate::extension::ExtensionValue`

Note that we have chosen not to rename the corresponding element of the
serialization schema.

BREAKING CHANGE: rename `crate::ops::constant::ExtensionValue` =>
`OpaqueValue`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants