Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use row variables for prelude panic op #1373

Closed
ss2165 opened this issue Jul 26, 2024 · 1 comment · Fixed by #1475
Closed

Use row variables for prelude panic op #1373

ss2165 opened this issue Jul 26, 2024 · 1 comment · Fixed by #1475
Assignees
@ss2165
Milestone
hugr-rs 0.12 / hu...

Comments

@ss2165
Copy link
Member

ss2165 commented Jul 26, 2024

Currently uses unecessary custom binary
@ss2165 ss2165 self-assigned this Aug 14, 2024
@ss2165
Copy link
Member Author

ss2165 commented Aug 14, 2024

should panic take static string?

ss2165 added a commit that referenced this issue Aug 27, 2024
@ss2165
refactor: use row variables for panic op
87bff45 
Closes #1373
@ss2165 ss2165 mentioned this issue Aug 27, 2024
Merged
ss2165 added a commit that referenced this issue Aug 27, 2024
@ss2165
refactor: use row variables for panic op
b743ccf 
Closes #1373
@ss2165 ss2165 added this to the hugr-rs 0.12.1 / hugr-py 0.8.1 milestone Aug 28, 2024
aborgna-q pushed a commit that referenced this issue Aug 29, 2024
@ss2165
feat!: Move Lift, MakeTuple, UnpackTuple and Lift to prelude (#…
b387505 
…1475)

Much of the noise is adding PRELUDE to extension inference tests. Add a
convenience `with_prelude()` method to Signature.

`Tag` left as a core operation as it is paramaterized by a variable
number of type rows.

Also drive-by get rid of custom signature use for print.

Closes #816
Closes #1373

BREAKING CHANGE: Move `Lift`, `MakeTuple`, `UnpackTuple` and `Lift` from
core operations to prelude. Rename `ops::leaf` module to `ops::sum`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ss2165 ss2165

Labels
None yet
Projects
None yet
Milestone
hugr-rs 0.12 / hugr-py 0.8
Development

Successfully merging a pull request may close this issue.

feat!: Move Lift, MakeTuple, UnpackTuple and Lift to prelude CQCL/hugr
1 participant
@ss2165