SVGIcon should render 'data-testid' (and all data- attributes)

[Josh68]

Describe the bug
SVGs should render data- attributes, according to spec (see also). SVGIcon (and therefore all other DS Icons), will not render these attributes.

There are bugs in Testing Library such that getByRole queries on images that are aria-hidden will not work with the name option (accessible name, referencing the SVG's title content), so using a data-testid attribute is the best fallback (the only one that works without resorting to plain CSS queries). Reference bug report

To Reproduce
Steps to reproduce the behavior:

1. Import any Icon or use the SVGIcon component with any valid SVG content
2. Pass in a data-testid prop. This is not flagged by TS, because it's valid
3. View the rendered SVG, which will have no data-testid attribute
4. Try with any basic HTML Element in JSX, such as a div
5. data-testid is rendered (as is any data- attribute)

Expected behavior
data- attributes are rendered

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

• OS: [OSX 12.4]
• Browser [Chrome]
• Version [latest]

Smartphone (please complete the following information):
N/A

Additional context
Add any other context about the problem here.

[scheul93]

👋🏻 Hi Josh, thanks for reporting this. I've got it logged in Jira . I'll talk to the team and get this prioritized.

[Josh68]

👋🏻 Hi Josh, thanks for reporting this. I've got it logged in Jira . I'll talk to the team and get this prioritized.

Thanks, @scheul93!

[scheul93]

A fix for this issue was just pushed out in our latest beta release (5.5.0-beta.1). It should be fully released on 6/16

[forrestbaer]

Fix has been fully released in 5.5.0