Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cice.setup broken for cases and tests since PR #395 #405

Closed
phil-blain opened this issue Feb 17, 2020 · 3 comments
Closed

cice.setup broken for cases and tests since PR #395 #405

phil-blain opened this issue Feb 17, 2020 · 3 comments

Comments

@phil-blain
Copy link
Member

Since PR #395 was merged it appears that cice.setup can't create cases or individual tests, in both cases I get a syntax error in the cice.setup script:

$ ./cice.setup --test smoke --mach cesium  -s diag1,debug --testid myid
 
./cice.setup:
else: endif not found.

I did not have time to find where is the error yet, just letting you know @apcraig.

We should add a call to cice.setup --case and cice.setup --test in the .travis.yml such that breakages like this do not go unnoticed in the future.

@phil-blain
Copy link
Member Author

I guess this would be high or extreme priority...

@apcraig
Copy link
Contributor

apcraig commented Feb 17, 2020

Thanks @phil-blain, I'll have a look and get a fix in this evening.

@apcraig
Copy link
Contributor

apcraig commented Feb 18, 2020

I just committed the fix #406 and added some tests to travis that would trap this in the future. Sorry about the error, I guess this'll happen occasionally. Glad we caught it fairly quickly. I will close this.

@apcraig apcraig closed this as completed Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants