Hyperbolic surface triangulation 2 (new package) #8259

loic-dubois · 2024-06-05T10:32:31Z

Summary of Changes

This package enables building and handling triangulations of closed orientable hyperbolic surfaces: a basic tool for any future implementation of algorithms operating on such surfaces. Functionalities are offered such as the Delaunay flip algorithm, and the construction of a portion of the lift of the triangulation in the Poincaré disk model of the hyperbolic plane. Triangulations can be generated by triangulating a convex fundamental domain in the Poincaré disk. A method is offered that generates such domains in genus two.

Release Management

Affected package(s): Hyperbolic_surface_triangulation_2
Issue(s) solved (if any): -
Feature/Small Feature (if any): https://cgal.geometryfactory.com/CGAL/Members/wiki/Features/Hyperbolic_Surface_Triangulation
Link to compiled documentation: link
License and copyright ownership: GPL INRIA

Merge branch 'Hyperbolic_surface_triangulation_2-dubois' of github.com:CGAL/cgal-public-dev into Hyperbolic_surface_triangulation_2-dubois

…m:CGAL/cgal-public-dev into Hyperbolic_surface_triangulation_2-dubois

afabri · 2024-06-05T11:07:57Z

/build:v0

github-actions · 2024-06-05T11:10:33Z

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/8259/v0/Manual/index.html

Hyperbolic_surface_triangulation_2/include/CGAL/Hyperbolic_fundamental_domain_2.h

pougetma · 2024-10-10T17:10:57Z

/force-build:v0

github-actions · 2024-10-10T17:14:19Z

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/8259/v0/Manual/index.html

afabri · 2024-10-10T18:22:31Z

...olic_surface_triangulation_2/doc/Hyperbolic_surface_triangulation_2/Concepts/ComplexNumber.h

+  /// \name Operations
+  /// @{
+  /*!
+    returns the square of the modulus.


These two functions are not member functions. Move them right behind the class and use the \relate command.

afabri · 2024-10-10T18:24:08Z

Hyperbolic_surface_triangulation_2/doc/Hyperbolic_surface_triangulation_2/dependencies

+Stream_support
+Number_types
+Combinatorial_map
+Hyperbolic_triangulation_2


Suggested change

Hyperbolic_triangulation_2

Hyperbolic_triangulation_2

Algebraic_foundations

Add this to get a link to Field

afabri · 2024-10-10T18:43:28Z

In the traits classes I only see constructions being made when I want Voronoi. Does that not mean that I could use the Exact_predicates_inexact_constructions_kernel?

In a model of a base concept of the traits class you write for exactness one needs the exact construction kernel with sqrt.

afabri · 2024-10-10T18:47:25Z

...rbolic_surface_triangulation_2/doc/Hyperbolic_surface_triangulation_2/PackageDescription.txt

+\cgalCRPSection{Concepts}
+
+- `HyperbolicSurfaceTraits_2` is the concept for the template parameter of most classes of the package.
+- `ComplexWithoutSqrt` describes a complex number type that does not use square root.


Suggested change

- `ComplexWithoutSqrt` describes a complex number type that does not use square root.

- `ComplexNumber` describes a complex number type that does not use square root.

…m:loic-dubois/cgal into Hyperbolic_surface_triangulation_2-dubois

pougetma · 2024-10-10T19:23:51Z

In the traits classes I only see constructions being made when I want Voronoi. Does that not mean that I could use the Exact_predicates_inexact_constructions_kernel?

In a model of a base concept of the traits class you write for exactness one needs the exact construction kernel with sqrt.

I tried EPIC in the test hs_test_triangulation_EPIC.cpp but I failed to construct a point from an exact rational ...

pougetma · 2024-10-15T07:59:01Z

/build:v1

github-actions · 2024-10-15T08:01:55Z

There was an error while building the doc:

error: Tag file '/home/runner/work/cgal/cgal/build_doc/doc_tags/Algebraic_foundationsw.tag' does not exist or is not a file. Skipping it...

https://github.com/CGAL/cgal/actions/runs/11341743466

pougetma · 2024-10-15T08:06:07Z

/build:v1

github-actions · 2024-10-15T08:11:39Z

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/8259/v1/Manual/index.html

pougetma · 2024-10-16T15:57:26Z

/build:v1

afabri · 2024-10-16T15:59:05Z

...ce_triangulation_2/doc/Hyperbolic_surface_triangulation_2/CGAL/Hyperbolic_surface_traits_2.h

+  /// @{
+  /*!
+          represents a complex number, model of
+          `ComplexNumber', over the field HyperbolicSurfaceTraits_2::FT for its real and


Suggested change

`ComplexNumber', over the field HyperbolicSurfaceTraits_2::FT for its real and

`ComplexNumber', over the field `HyperbolicSurfaceTraits_2::FT` for its real and

github-actions · 2024-10-16T16:00:36Z

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/8259/v1/Manual/index.html

sloriot · 2024-12-24T07:33:07Z

Red testsuite in CGAL-6.1-Ic-47

loic-dubois and others added 19 commits March 7, 2024 08:16

initialisation

72405a4

Ajout du code

449cfa4

remplissage du README

a3b1e0f

bug fix

4ee74ee

changed cmap copy into copy from const

3aab28f

version 0 de la doc

c1eb7f0

new point type

e799290

documentation almost finished up to user manual

6b424b1

user manual

3d1d728

finished with user manual

1f1ca86

add non-separating

471b3bb

doc improvement

497c88a

doc update

263f7ea

added an explicit cast since my compiler complains

f794cd9

Merge branch 'Hyperbolic_surface_triangulation_2-dubois' of github.com:CGAL/cgal-public-dev into Hyperbolic_surface_triangulation_2-dubois

doc update

d10f85d

Merge branch 'Hyperbolic_surface_triangulation_2-dubois' of github.co…

f72fa67

…m:CGAL/cgal-public-dev into Hyperbolic_surface_triangulation_2-dubois

update doc 2

dec801d

update

0eae2cf

minor patches

c4eea02

MaelRL added Not yet approved The feature or pull-request has not yet been approved. Feature labels Jun 5, 2024

MaelRL added this to the 6.1-beta milestone Jun 5, 2024

MaelRL changed the title ~~Hyperbolic surface triangulation 2 dubois~~ Hyperbolic surface triangulation 2 (new package) Jun 5, 2024

Fix dependencies

88576a0

afabri reviewed Jun 5, 2024

View reviewed changes

Hyperbolic_surface_triangulation_2/include/CGAL/Hyperbolic_fundamental_domain_2.h Outdated Show resolved Hide resolved

afabri reviewed Jun 5, 2024

View reviewed changes

Hyperbolic_surface_triangulation_2/include/CGAL/Hyperbolic_fundamental_domain_2.h Outdated Show resolved Hide resolved

afabri reviewed Jun 5, 2024

View reviewed changes

Hyperbolic_surface_triangulation_2/include/CGAL/Hyperbolic_fundamental_domain_2.h Outdated Show resolved Hide resolved

afabri reviewed Jun 5, 2024

View reviewed changes

Hyperbolic_surface_triangulation_2/include/CGAL/Hyperbolic_fundamental_domain_2.h Outdated Show resolved Hide resolved

pougetma added 2 commits October 10, 2024 17:29

simplified #includes

ce29adf

change naming conj, norm for complex

9dca1b6

afabri reviewed Oct 10, 2024

View reviewed changes

prefix with CGAL:: in concept doc

c976fc4

afabri reviewed Oct 10, 2024

View reviewed changes

pougetma added 3 commits October 10, 2024 20:49

doc correction with complex nb

c193c99

Merge branch 'Hyperbolic_surface_triangulation_2-dubois' of github.co…

fa7a268

…m:loic-dubois/cgal into Hyperbolic_surface_triangulation_2-dubois

trying to use EPIC

33ce1a8

rm EPIC test

3463e8a

typo

c7bc218

doc details for complex nb

374dbf1

afabri reviewed Oct 16, 2024

View reviewed changes

typo

92f2042

MaelRL added the TODO (web) label Dec 9, 2024

sloriot added Under Testing and removed Tests failing labels Dec 23, 2024

sloriot added Tests failing and removed Under Testing labels Dec 24, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Hyperbolic surface triangulation 2 (new package) #8259

Hyperbolic surface triangulation 2 (new package) #8259

loic-dubois commented Jun 5, 2024 •

edited by afabri

Loading

afabri commented Jun 5, 2024

github-actions bot commented Jun 5, 2024

pougetma commented Oct 10, 2024

github-actions bot commented Oct 10, 2024

afabri Oct 10, 2024

afabri Oct 10, 2024

afabri commented Oct 10, 2024 •

edited

Loading

afabri Oct 10, 2024

pougetma commented Oct 10, 2024

pougetma commented Oct 15, 2024

github-actions bot commented Oct 15, 2024

pougetma commented Oct 15, 2024

github-actions bot commented Oct 15, 2024

pougetma commented Oct 16, 2024

afabri Oct 16, 2024

github-actions bot commented Oct 16, 2024

sloriot commented Dec 24, 2024

	Hyperbolic_triangulation_2
	Hyperbolic_triangulation_2
	Algebraic_foundations

	- `ComplexWithoutSqrt` describes a complex number type that does not use square root.
	- `ComplexNumber` describes a complex number type that does not use square root.

	`ComplexNumber', over the field HyperbolicSurfaceTraits_2::FT for its real and
	`ComplexNumber', over the field `HyperbolicSurfaceTraits_2::FT` for its real and

Hyperbolic surface triangulation 2 (new package) #8259

Are you sure you want to change the base?

Hyperbolic surface triangulation 2 (new package) #8259

Conversation

loic-dubois commented Jun 5, 2024 • edited by afabri Loading

Summary of Changes

Release Management

afabri commented Jun 5, 2024

github-actions bot commented Jun 5, 2024

pougetma commented Oct 10, 2024

github-actions bot commented Oct 10, 2024

afabri Oct 10, 2024

Choose a reason for hiding this comment

afabri Oct 10, 2024

Choose a reason for hiding this comment

afabri commented Oct 10, 2024 • edited Loading

afabri Oct 10, 2024

Choose a reason for hiding this comment

pougetma commented Oct 10, 2024

pougetma commented Oct 15, 2024

github-actions bot commented Oct 15, 2024

pougetma commented Oct 15, 2024

github-actions bot commented Oct 15, 2024

pougetma commented Oct 16, 2024

afabri Oct 16, 2024

Choose a reason for hiding this comment

github-actions bot commented Oct 16, 2024

sloriot commented Dec 24, 2024

loic-dubois commented Jun 5, 2024 •

edited by afabri

Loading

afabri commented Oct 10, 2024 •

edited

Loading