Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code urls not working for projects outside of github.com/cdcgov #31

Closed
leebrian opened this issue Jan 29, 2019 · 3 comments
Closed

Code urls not working for projects outside of github.com/cdcgov #31

leebrian opened this issue Jan 29, 2019 · 3 comments

Comments

@leebrian
Copy link
Member

@mlamtamri found the following bug after adding info on Epi Info’s project... (#29)

“Hi Brian, The Epi info repository link is broken. Epi info products have their own repository in GitHub. They don’t exist under https://github.com/CDCgovhttps://github.com/CDCgov/SDP-Vocabulary-Service. Any suggestion on how to fix this issue?”

@drewry
Copy link
Member

drewry commented Jan 29, 2019

This is because of this in the layout:

<a href="https://github.com/CDCgov/{{ repo.url }}" target="_blank">

One suggestion would be to add a org: MY_ORG field into the yml and if passed it triggers a conditional to use that org instead of the default CDCgov.

The reason for capturing the org as there’s a feature for being able to search tags within a set of repos and the org field is required for that.

@leebrian
Copy link
Member Author

Yep. I think I’m going to refactor to just use a full url. This would be easier for users, I think, and also allow for more flexibility in case orgs have projects with different urls (eg, blockchain has a project in github/CDCgov and github/informaticslab or something). I’ll update when near a device with a decent dev environment.

@leebrian
Copy link
Member Author

Fixed in v1.0.3

Now urls for code items can go anywhere, like cool orgs like github/Epi-Info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants