Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor AR process #328

Closed
damonbayer opened this issue Jul 25, 2024 · 2 comments · Fixed by #380
Closed

Refactor AR process #328

damonbayer opened this issue Jul 25, 2024 · 2 comments · Fixed by #380
Assignees
@dylanhmorris
Labels
clean up Good code that could be better
Milestone
🐦 Qiupalong

Comments

@damonbayer
Copy link
Collaborator

damonbayer commented Jul 25, 2024 •
edited
Loading

We should clean up https://github.com/CDCgov/multisignal-epi-inference/blob/main/model/src/pyrenew/process/ar.py to reflect recent design decisions. This work should be similar to the work done in #275.

We should also look around at other examples to see if we can learn any lessons:
@damonbayer damonbayer added this to the 🦆 Olorotitan milestone Jul 25, 2024
@damonbayer damonbayer added the clean up Good code that could be better label Jul 25, 2024
@damonbayer
Copy link
Collaborator Author

damonbayer commented Jul 25, 2024 •
edited
Loading

Also related: #214 and #329

@damonbayer damonbayer mentioned this issue Jul 25, 2024
Closed
@AFg6K7h4fhy2 AFg6K7h4fhy2 mentioned this issue Jul 26, 2024
Closed
4 tasks
@dylanhmorris dylanhmorris mentioned this issue Jul 26, 2024
Merged
@dylanhmorris
Copy link
Collaborator

#262 (comment)

@damonbayer damonbayer modified the milestone: 🦆 Olorotitan Aug 2, 2024
@dylanhmorris dylanhmorris mentioned this issue Aug 15, 2024
Merged
@dylanhmorris dylanhmorris linked a pull request Aug 15, 2024 that will close this issue
Refactor differenced processes, random walks, and AR processes #380
Merged
@damonbayer damonbayer modified the milestones: 🦆 Olorotitan, P Sprint Aug 15, 2024
@dylanhmorris dylanhmorris mentioned this issue Aug 16, 2024
Closed
@damonbayer damonbayer modified the milestones: P Sprint, Q Sprint Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dylanhmorris dylanhmorris

Labels
clean up Good code that could be better
Projects
None yet
Milestone
🐦 Qiupalong
Development

Successfully merging a pull request may close this issue.

Refactor differenced processes, random walks, and AR processes CDCgov/PyRenew
2 participants
@dylanhmorris @damonbayer