Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't test against Azurite because Azure host is hardcoded #224

Open
NathanBaulch opened this issue Jan 14, 2025 · 1 comment
Open

Can't test against Azurite because Azure host is hardcoded #224

NathanBaulch opened this issue Jan 14, 2025 · 1 comment

Comments

@NathanBaulch
Copy link
Contributor

I'd like to be able to test an Azure backend against https://github.com/Azure/Azurite running locally, however I quickly discovered that unlike the other cloud backends, Azure is hardcoded with blob.core.windows.net.

It's also a bit odd that the Azure backend uses the general https:// scheme and seems to get special treatment in vfssimple which calls azure.IsValidURI.

I think it'd be a good idea to make the Azure backend consistent with the other cloud backends by introducing an az:// scheme and letting the underlying client decide the target host. Speaking of clients, it would be also be good to get rid of azure.DefaultClient and simply use/mock the standard azure-sdk-for-go client.

@funkyshu
Copy link
Member

I never liked the scheme as http. We built the backend intending to use azure blob for a specific client but when the deal fell through, so did the development on that backend. I've considered deprecating it. I'm open to any PR you have for this including changing the scheme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants