From 1892b709b87683082e4dce230d052e0c41218264 Mon Sep 17 00:00:00 2001 From: Cameron Hessler Date: Sun, 29 Oct 2023 02:43:47 -0500 Subject: [PATCH] Remove intermediate render cycle from useEditor Possibly fixes #3345 --- demos/src/Commands/Cut/React/index.jsx | 4 ---- demos/src/Examples/Book/React/index.jsx | 4 ---- demos/src/Examples/CSSModules/React/index.jsx | 4 ---- demos/src/Examples/CodeBlockLanguage/React/index.jsx | 4 ---- demos/src/Examples/Default/React/index.jsx | 4 ---- demos/src/Examples/Formatting/React/index.jsx | 4 ---- demos/src/Examples/Tables/React/index.jsx | 4 ---- demos/src/Experiments/IsolatingClear/React/index.jsx | 4 ---- demos/src/Extensions/CharacterCount/React/index.jsx | 4 ---- demos/src/Extensions/Color/React/index.jsx | 4 ---- demos/src/Extensions/History/React/index.jsx | 4 ---- demos/src/Extensions/ListKeymap/React/index.jsx | 4 ---- demos/src/Extensions/TextAlign/React/index.jsx | 4 ---- demos/src/GuideContent/ExportJSON/React/index.jsx | 8 -------- demos/src/GuideContent/ReadOnly/React/index.jsx | 8 -------- .../GuideNodeViews/TableOfContents/React/Component.jsx | 4 ---- demos/src/GuideNodeViews/TableOfContents/React/index.jsx | 4 ---- demos/src/Marks/Bold/React/index.jsx | 4 ---- demos/src/Marks/Code/React/index.jsx | 4 ---- demos/src/Marks/Highlight/React/index.jsx | 4 ---- demos/src/Marks/Italic/React/index.jsx | 4 ---- demos/src/Marks/Link/React/index.jsx | 4 ---- demos/src/Marks/Strike/React/index.jsx | 4 ---- demos/src/Marks/Subscript/React/index.jsx | 4 ---- demos/src/Marks/Superscript/React/index.jsx | 4 ---- demos/src/Marks/TextStyle/React/index.jsx | 4 ---- demos/src/Marks/Underline/React/index.jsx | 4 ---- demos/src/Nodes/Blockquote/React/index.jsx | 4 ---- demos/src/Nodes/BulletList/React/index.jsx | 4 ---- demos/src/Nodes/CodeBlock/React/index.jsx | 4 ---- demos/src/Nodes/CodeBlockLowlight/React/index.jsx | 4 ---- demos/src/Nodes/Document/React/index.jsx | 4 ---- demos/src/Nodes/HardBreak/React/index.jsx | 4 ---- demos/src/Nodes/Heading/React/index.jsx | 4 ---- demos/src/Nodes/HorizontalRule/React/index.jsx | 4 ---- demos/src/Nodes/Image/React/index.jsx | 4 ---- demos/src/Nodes/ListItem/React/index.jsx | 4 ---- demos/src/Nodes/Mention/React/index.jsx | 4 ---- demos/src/Nodes/OrderedList/React/index.jsx | 4 ---- demos/src/Nodes/Paragraph/React/index.jsx | 4 ---- demos/src/Nodes/Table/React/index.jsx | 4 ---- demos/src/Nodes/TaskItem/React/index.jsx | 4 ---- demos/src/Nodes/TaskList/React/index.jsx | 4 ---- demos/src/Nodes/Text/React/index.jsx | 4 ---- demos/src/Nodes/Youtube/React/index.jsx | 4 ---- demos/src/Tutorials/1-2-tiptap/React/Note.tsx | 2 +- packages/react/src/Context.tsx | 4 ---- packages/react/src/EditorContent.tsx | 6 +----- packages/react/src/useEditor.ts | 8 ++------ 49 files changed, 4 insertions(+), 204 deletions(-) diff --git a/demos/src/Commands/Cut/React/index.jsx b/demos/src/Commands/Cut/React/index.jsx index 3b5164055e3..0ede480b679 100644 --- a/demos/src/Commands/Cut/React/index.jsx +++ b/demos/src/Commands/Cut/React/index.jsx @@ -8,10 +8,6 @@ import StarterKit from '@tiptap/starter-kit' import React, { useCallback } from 'react' const MenuBar = ({ editor }) => { - if (!editor) { - return null - } - const onCutToStart = useCallback(() => { editor.chain().cut({ from: editor.state.selection.$from.pos, to: editor.state.selection.$to.pos }, 1).run() }, [editor]) diff --git a/demos/src/Examples/Book/React/index.jsx b/demos/src/Examples/Book/React/index.jsx index b09b08eebcd..09f498b74db 100644 --- a/demos/src/Examples/Book/React/index.jsx +++ b/demos/src/Examples/Book/React/index.jsx @@ -7,10 +7,6 @@ import React from 'react' import { content } from '../content.js' const MenuBar = ({ editor }) => { - if (!editor) { - return null - } - return ( <> diff --git a/demos/src/Nodes/Heading/React/index.jsx b/demos/src/Nodes/Heading/React/index.jsx index d80f5b84711..cb55f0ece0b 100644 --- a/demos/src/Nodes/Heading/React/index.jsx +++ b/demos/src/Nodes/Heading/React/index.jsx @@ -23,10 +23,6 @@ export default () => { `, }) - if (!editor) { - return null - } - return ( <> diff --git a/demos/src/Nodes/ListItem/React/index.jsx b/demos/src/Nodes/ListItem/React/index.jsx index 851edb9db25..cda6cdb12b5 100644 --- a/demos/src/Nodes/ListItem/React/index.jsx +++ b/demos/src/Nodes/ListItem/React/index.jsx @@ -35,10 +35,6 @@ export default () => { `, }) - if (!editor) { - return null - } - return ( <>