Adding support for handling SpellCheck.IsEnabled on TextBoxes. #650
+176
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #497
Though I understand that the intent it for this library to be a theme library, not a control library, it seems like a loss in functionality for someone moving from standard WPF.
The intent of this was to simply handle the cases where someone merely sets
SpellCheck.IsEnabled="True"
and then includes this theme library.I have attempted to handle all possible cases, with a few things in particular worth pointing out.
TextFieldAssist.IncludeSpellingSuggestions
, and bound its default value toSpellCheck.IsEnabled
. This should allow for people wanting to roll their own UI for the spell check (and thus haveSpellCheck.IsEnabled="True"
), and simply want to opt-out of the behavior for including these in the context menu.Thoughts?