Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"(Yes, ack has a bug.)" appears to be outdated #1506

Closed
matkoniecz opened this issue Mar 3, 2020 · 2 comments
Closed

"(Yes, ack has a bug.)" appears to be outdated #1506

matkoniecz opened this issue Mar 3, 2020 · 2 comments

Comments

@matkoniecz
Copy link
Contributor

https://github.com/BurntSushi/ripgrep#quick-examples-comparing-tools has "(Yes, ack has a bug.)" linking to beyondgrep/ack2#445 and beyondgrep/ack2#14

Both are closed. So either ack fixed this bug or wontfixed it. It probably should be rerun and updated to either to not list ack as buggy or to mention that ack is buggy and it was kept as "feature"
@matkoniecz
Copy link
Contributor Author

I now found #1474 (comment) so "has a bug" is true and will be true forever.

Though maybe it is worth clarifying.

@BurntSushi
Copy link
Owner

I think my stance is still the same here. At some point, I will redo the benchmarks and upgrade to ack3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@BurntSushi @matkoniecz