Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DuctSystem/MaximumOAFlowRate Rename #296

Closed
corymosiman12 opened this issue Feb 17, 2021 · 2 comments · Fixed by #395 or #396
Closed

DuctSystem/MaximumOAFlowRate Rename #296

corymosiman12 opened this issue Feb 17, 2021 · 2 comments · Fixed by #395 or #396
Assignees
@JieXiong9119
Labels
Breaking Change

Comments

@corymosiman12
Copy link
Contributor

All other elements use OutsideAir. Suggest deprecation and element rename to MaximumOutsideAirFlowRate

Describe the bug or data model issue

Expected Behavior

Actual Behavior

Additional Context
@nllong
Copy link
Member

nllong commented Sep 21, 2021

@JieXiong9119, is this something that we plan on getting into V3? Seems like a straightforward change.

@JieXiong9119
Copy link
Contributor

@JieXiong9119, is this something that we plan on getting into V3? Seems like a straightforward change.

We never discuss to decide if we would like to proceed this. It is straightforward though.

@JieXiong9119 JieXiong9119 mentioned this issue Sep 28, 2021
Merged
@JieXiong9119 JieXiong9119 linked a pull request Sep 28, 2021 that will close this issue
Add MaximumOutsideAirFlowRate #395
Merged
@JieXiong9119 JieXiong9119 mentioned this issue Sep 29, 2021
Merged
@JieXiong9119 JieXiong9119 linked a pull request Sep 29, 2021 that will close this issue
Deprecate MaximumOAFlowRate #396
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JieXiong9119 JieXiong9119

Labels
Breaking Change
Projects
None yet
Milestone
No milestone
3 participants
@nllong @corymosiman12 @JieXiong9119