Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in auc:eGRIDRegionCode enumeration #276

Closed
markborkum opened this issue Dec 4, 2020 · 2 comments
Closed

Fix typo in auc:eGRIDRegionCode enumeration #276

markborkum opened this issue Dec 4, 2020 · 2 comments
Labels
bug Non-breaking Change Schema: General General update to BuildingSync

Comments

@markborkum
Copy link
Contributor

markborkum commented Dec 4, 2020 •
edited
Loading

"MORE" should be "MROE"

This issue also effects BEDES: https://bedes.lbl.gov/bedes-online/more
@markborkum markborkum added the bug label Dec 4, 2020
@nllong
Copy link
Member

nllong commented Dec 15, 2020

Nice find. I'll tag this for Version 3.0 fix since it will be a breaking change.

@nllong nllong mentioned this issue Dec 16, 2020
Merged
@nllong nllong closed this as completed Dec 16, 2020
@nllong nllong mentioned this issue Dec 16, 2020
Closed
@nllong
Copy link
Member

nllong commented Dec 16, 2020

resolved by adding MROE. Will deprecate MORE in V3.0 per #283

@JieXiong9119 JieXiong9119 added Non-breaking Change Schema: General General update to BuildingSync labels Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Non-breaking Change Schema: General General update to BuildingSync
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@markborkum @nllong @JieXiong9119