Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add LinkedPremises to FanSystem and MotorSystem #189

Closed
corymosiman12 opened this issue Jun 30, 2020 · 2 comments · Fixed by #192
Closed

Add LinkedPremises to FanSystem and MotorSystem #189

corymosiman12 opened this issue Jun 30, 2020 · 2 comments · Fixed by #192

Comments

@corymosiman12
Copy link
Contributor

Unlike most other systems, FanSystems and PumpSystems are missing a branch for LinkedPremises, including LinkedSchedule.

To be clear, these are the paths:

  • BuildingSync>Facilities>Facility>Systems>FanSystems>FanSystem
  • BuildingSync>Facilities>Facility>Systems>PumpSystems>PumpSystem

And normally, we'd expect a child path of:

  • LinkedPremises>Building>LinkedBuildingID>LinkedScheduleIDs>LinkedScheduleID

This issue is to add those in there.
@corymosiman12 corymosiman12 linked a pull request Jul 9, 2020 that will close this issue
add LinkedPremises to FanSystem and MotorSystem #192
Merged
@avesk
Copy link

avesk commented Jul 9, 2020

Hey! Also noticed that the same issue exists on BuildingSync>Facilities>Facility>Systems>HVACSystems>HVACSystem>HeatingAndCoolingSystems>HeatingSources>HeatingSource

@avesk
Copy link

avesk commented Jul 14, 2020

BuildingSync>Facilities>Facility>Systems>HVACSystems>HVACSystem>HeatingAndCoolingSystems>HeatingSources>HeatingSource

Turns out using BuildingSync>Facilities>Facility>Systems>HVACSystems>HVACSystem> will satisfy our use case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add LinkedPremises to FanSystem and MotorSystem BuildingSync/schema
2 participants
@avesk @corymosiman12