Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is anyone working on fixing these issues? #50

Open
teknology opened this issue Apr 27, 2024 · 4 comments
Open

Is anyone working on fixing these issues? #50

teknology opened this issue Apr 27, 2024 · 4 comments

Comments

@teknology
Copy link

Is this repo abandonned?

@chrisemoulton
Copy link

chrisemoulton commented Jun 25, 2024

I'm pretty sure that's the case as the underlying source doesn't seem to be maintained. Just spent a few days integrating with a next.js project and there are a few major issues trying to deploy into production.

@steve8708
Copy link
Contributor

what issues did you hit @chrisemoulton ? we try to keep on top of major issues that are reported

@chrisemoulton
Copy link

chrisemoulton commented Jun 25, 2024

hey @steve8708. Thanks for the quick response.

I have two that keep persisting! Dev environment runs fine but I am looking to deploy into production asap.

The first is an unescaped / traced back to the initial repo/css minification during build?

The second is a type error in ./components/modals/index.tsx:21:14
Type error: The inferred type of 'AnimatedDialogOverlay' cannot be named without a reference to '.pnpm/@reach+polymorphic@0.18.0_react@18.2.0/node_modules/@reach/polymorphic'. This is likely not portable. A type annotation is necessary.

1.md
2.md

I attached a list of the outdated sub dependancies in 2 as there are some potential compatibility issues at play?

Chris

@teleaziz
Copy link
Contributor

teleaziz commented Jul 7, 2024

@chrisemoulton would you mind elaborating more on the production deployment issues you see, I just tested full flow forking from master and don't see any issues in deployment https://nextjs-shopify-july.vercel.app/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants