fix: better error for invalid client id or client secret #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobbyg603
commented
Oct 18, 2022
...ommon/client/oauth-client-credentials-api-client/oauth-client-credentials-api-client.spec.ts
Outdated
Show resolved
Hide resolved
…auth-client-credentials-api-client.spec.ts
1 task
daveplunkett
approved these changes
Oct 19, 2022
bobbyg603
pushed a commit
that referenced
this pull request
Oct 19, 2022
## [2.1.1](v2.1.0...v2.1.1) (2022-10-19) ### Bug Fixes * better error for invalid client id or client secret ([#84](#84)) ([16b349a](16b349a))
|
🎉 This PR is included in version 2.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 401 case is a tricky one, you can have a valid token, but if it can't access the specific resource a 401 error happens late in the request chain. We want to catch 401 errors and give at least some sort of helpful error message.