Add tests and UI updates

Author: tysonthomas9

config/gni/devtools_grd_files.gni

@@ -656,6 +656,7 @@ grd_files_bundled_sources = [
   "front_end/panels/ai_chat/ui/mcp/MCPConnectionsDialog.js",
   "front_end/panels/ai_chat/ui/mcp/MCPConnectorsCatalogDialog.js",
   "front_end/panels/ai_chat/ui/EvaluationDialog.js",
+  "front_end/panels/ai_chat/ui/WebAppCodeViewer.js",
   "front_end/panels/ai_chat/core/AgentService.js",
   "front_end/panels/ai_chat/core/State.js",
   "front_end/panels/ai_chat/core/Graph.js",
@@ -676,6 +677,7 @@ grd_files_bundled_sources = [
   "front_end/panels/ai_chat/core/AgentDescriptorRegistry.js",
   "front_end/panels/ai_chat/core/Version.js",
   "front_end/panels/ai_chat/core/VersionChecker.js",
+  "front_end/panels/ai_chat/core/LLMConfigurationManager.js",
   "front_end/panels/ai_chat/LLM/LLMTypes.js",
   "front_end/panels/ai_chat/LLM/LLMProvider.js",
   "front_end/panels/ai_chat/LLM/LLMProviderRegistry.js",
@@ -702,6 +704,15 @@ grd_files_bundled_sources = [
   "front_end/panels/ai_chat/tools/BookmarkStoreTool.js",
   "front_end/panels/ai_chat/tools/DocumentSearchTool.js",
   "front_end/panels/ai_chat/tools/ThinkingTool.js",
+  "front_end/panels/ai_chat/tools/RenderWebAppTool.js",
+  "front_end/panels/ai_chat/tools/GetWebAppDataTool.js",
+  "front_end/panels/ai_chat/tools/RemoveWebAppTool.js",
+  "front_end/panels/ai_chat/tools/FileStorageManager.js",
+  "front_end/panels/ai_chat/tools/CreateFileTool.js",
+  "front_end/panels/ai_chat/tools/UpdateFileTool.js",
+  "front_end/panels/ai_chat/tools/DeleteFileTool.js",
+  "front_end/panels/ai_chat/tools/ReadFileTool.js",
+  "front_end/panels/ai_chat/tools/ListFilesTool.js",
   "front_end/panels/ai_chat/common/utils.js",
   "front_end/panels/ai_chat/common/log.js",
   "front_end/panels/ai_chat/common/context.js",

front_end/panels/ai_chat/BUILD.gn

@@ -42,6 +42,7 @@ devtools_module("ai_chat") {
     "ui/SettingsDialog.ts",
     "ui/PromptEditDialog.ts",
     "ui/EvaluationDialog.ts",
+    "ui/WebAppCodeViewer.ts",
     "ai_chat_impl.ts",
     "models/ChatTypes.ts",
     "core/Graph.ts",
@@ -206,6 +207,7 @@ _ai_chat_sources = [
     "ui/PromptEditDialog.ts",
     "ui/SettingsDialog.ts",
     "ui/EvaluationDialog.ts",
+    "ui/WebAppCodeViewer.ts",
     "ui/mcp/MCPConnectionsDialog.ts",
     "ui/mcp/MCPConnectorsCatalogDialog.ts",
     "ai_chat_impl.ts",
@@ -265,6 +267,9 @@ _ai_chat_sources = [
     "tools/ListFilesTool.ts",
     "tools/SequentialThinkingTool.ts",
     "tools/ThinkingTool.ts",
+    "tools/RenderWebAppTool.ts",
+    "tools/GetWebAppDataTool.ts",
+    "tools/RemoveWebAppTool.ts",
     "agent_framework/ConfigurableAgentTool.ts",
     "agent_framework/AgentRunner.ts",
     "agent_framework/AgentRunnerEventBus.ts",
@@ -408,6 +413,7 @@ ts_library("unittests") {
     "ui/__tests__/ChatViewSequentialSessionsTransition.test.ts",
     "ui/__tests__/ChatViewInputClear.test.ts",
     "ui/__tests__/SettingsDialogOpenRouterCache.test.ts",
+    "ui/__tests__/WebAppCodeViewer.test.ts",
     "ui/input/__tests__/InputBarClear.test.ts",
     "ui/message/__tests__/MessageCombiner.test.ts",
     "ui/message/__tests__/StructuredResponseController.test.ts",
@@ -428,6 +434,11 @@ ts_library("unittests") {
     "ui/__tests__/AIChatPanel.test.ts",
     "ui/__tests__/LiveAgentSessionComponent.test.ts",
     "ui/message/__tests__/MessageList.test.ts",
+    "tools/__tests__/CreateFileTool.test.ts",
+    "tools/__tests__/UpdateFileTool.test.ts",
+    "tools/__tests__/ReadFileTool.test.ts",
+    "tools/__tests__/ListFilesTool.test.ts",
+    "tools/__tests__/FileStorageManager.test.ts",
   ]
 
   deps = [

front_end/panels/ai_chat/tools/__tests__/CreateFileTool.test.ts

@@ -0,0 +1,52 @@
+// Copyright 2025 The Chromium Authors
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+import {CreateFileTool} from '../CreateFileTool.js';
+import {FileStorageManager, type StoredFile} from '../FileStorageManager.js';
+
+describe('CreateFileTool', () => {
+  afterEach(() => {
+    sinon.restore();
+  });
+
+  it('creates a file successfully', async () => {
+    const stored: StoredFile = {
+      id: 'id-123',
+      sessionId: 'sess-1',
+      fileName: 'note.txt',
+      content: 'hello',
+      mimeType: 'text/plain',
+      createdAt: Date.now(),
+      updatedAt: Date.now(),
+      size: 5,
+    };
+
+    const fakeManager = {createFile: sinon.stub().resolves(stored)} as unknown as FileStorageManager;
+    sinon.stub(FileStorageManager, 'getInstance').returns(fakeManager);
+
+    const tool = new CreateFileTool();
+    const result = await tool.execute({fileName: 'note.txt', content: 'hello', reasoning: 'store note'});
+
+    assert.strictEqual(result.success, true);
+    assert.strictEqual(result.fileName, 'note.txt');
+    assert.strictEqual(result.fileId, 'id-123');
+    assert.isString(result.message);
+    assert.match(result.message!, /Created file "note\.txt" \(\d+ bytes\)\./);
+
+    sinon.assert.calledOnce((fakeManager as any).createFile);
+    sinon.assert.calledWithExactly((fakeManager as any).createFile, 'note.txt', 'hello', undefined);
+  });
+
+  it('returns an error when creation fails', async () => {
+    const fakeManager = {createFile: sinon.stub().rejects(new Error('boom'))} as unknown as FileStorageManager;
+    sinon.stub(FileStorageManager, 'getInstance').returns(fakeManager);
+
+    const tool = new CreateFileTool();
+    const result = await tool.execute({fileName: 'note.txt', content: 'hello', reasoning: 'store note'});
+
+    assert.strictEqual(result.success, false);
+    assert.strictEqual(result.error, 'boom');
+  });
+});
+

front_end/panels/ai_chat/tools/__tests__/FileStorageManager.test.ts

@@ -0,0 +1,88 @@
+// Copyright 2025 The Chromium Authors
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+import {FileStorageManager, type StoredFile, type FileSummary} from '../FileStorageManager.js';
+
+describe('FileStorageManager', () => {
+  beforeEach(() => {
+    // Reset singleton to avoid session bleed between tests
+    (FileStorageManager as unknown as {instance: FileStorageManager|null}).instance = null;
+  });
+
+  it('creates, reads, lists and deletes files end-to-end', async () => {
+    const mgr = FileStorageManager.getInstance();
+
+    const f1 = await mgr.createFile('f1.txt', 'Hello', 'text/plain');
+    assert.strictEqual(f1.fileName, 'f1.txt');
+    assert.strictEqual(f1.content, 'Hello');
+    assert.strictEqual(f1.mimeType, 'text/plain');
+
+    const f2 = await mgr.createFile('f2.txt', 'World');
+    assert.strictEqual(f2.fileName, 'f2.txt');
+
+    const read = await mgr.readFile('f1.txt');
+    assert.isNotNull(read);
+    assert.strictEqual(read?.content, 'Hello');
+
+    const files: FileSummary[] = await mgr.listFiles();
+    const names = new Set(files.map(f => f.fileName));
+    assert.isTrue(names.has('f1.txt'));
+    assert.isTrue(names.has('f2.txt'));
+    if (files.length >= 2) {
+      assert.isAtLeast(files[0].createdAt, files[1].createdAt);
+    }
+
+    await mgr.deleteFile('f1.txt');
+    const afterDelete = await mgr.readFile('f1.txt');
+    assert.isNull(afterDelete);
+  });
+
+  it('prevents duplicate filenames within the same session', async () => {
+    const mgr = FileStorageManager.getInstance();
+    await mgr.createFile('dup.txt', 'a');
+    try {
+      await mgr.createFile('dup.txt', 'b');
+      assert.fail('Expected duplicate create to throw');
+    } catch (e: any) {
+      assert.match(String(e?.message || e), /already exists/i);
+    }
+  });
+
+  it('validates file name rules', async () => {
+    const mgr = FileStorageManager.getInstance();
+
+    async function expectRejected(p: Promise<unknown>, re: RegExp) {
+      try {
+        await p;
+        assert.fail('Expected promise to reject');
+      } catch (e: any) {
+        assert.match(String(e?.message || e), re);
+      }
+    }
+
+    await expectRejected(mgr.createFile('', 'x'), /cannot be empty/i);
+    await expectRejected(mgr.createFile('a/b', 'x'), /path separators/i);
+    const tooLong = 'a'.repeat(256);
+    await expectRejected(mgr.createFile(tooLong, 'x'), /255 characters or fewer/i);
+  });
+
+  it('updateFile supports append and replace semantics', async () => {
+    const mgr = FileStorageManager.getInstance();
+    await mgr.createFile('note.txt', 'A');
+
+    const appended: StoredFile = await mgr.updateFile('note.txt', 'B', true);
+    assert.strictEqual(appended.content, 'AB');
+    assert.isAtLeast(appended.size, 2);
+
+    const replaced: StoredFile = await mgr.updateFile('note.txt', 'C', false);
+    assert.strictEqual(replaced.content, 'C');
+    assert.strictEqual(replaced.size, new TextEncoder().encode('C').length);
+  });
+
+  it('readFile returns null when missing', async () => {
+    const mgr = FileStorageManager.getInstance();
+    const missing = await mgr.readFile('does-not-exist.txt');
+    assert.isNull(missing);
+  });
+});

front_end/panels/ai_chat/tools/__tests__/ListFilesTool.test.ts

@@ -0,0 +1,42 @@
+// Copyright 2025 The Chromium Authors
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+import {ListFilesTool} from '../ListFilesTool.js';
+import {FileStorageManager, type FileSummary} from '../FileStorageManager.js';
+
+describe('ListFilesTool', () => {
+  afterEach(() => {
+    sinon.restore();
+  });
+
+  it('lists files successfully and returns count', async () => {
+    const now = Date.now();
+    const files: FileSummary[] = [
+      {fileName: 'b.txt', size: 2, mimeType: 'text/plain', createdAt: now - 2, updatedAt: now - 1},
+      {fileName: 'a.txt', size: 1, mimeType: 'text/plain', createdAt: now - 3, updatedAt: now - 2},
+    ];
+    const fakeManager = {listFiles: sinon.stub().resolves(files)} as unknown as FileStorageManager;
+    sinon.stub(FileStorageManager, 'getInstance').returns(fakeManager);
+
+    const tool = new ListFilesTool();
+    const result = await tool.execute({reasoning: 'enumerate'});
+
+    assert.strictEqual(result.success, true);
+    assert.deepEqual(result.files, files);
+    assert.strictEqual(result.count, files.length);
+    sinon.assert.calledOnce((fakeManager as any).listFiles);
+  });
+
+  it('returns an error when listing fails', async () => {
+    const fakeManager = {listFiles: sinon.stub().rejects(new Error('no db'))} as unknown as FileStorageManager;
+    sinon.stub(FileStorageManager, 'getInstance').returns(fakeManager);
+
+    const tool = new ListFilesTool();
+    const result = await tool.execute({reasoning: 'enumerate'});
+
+    assert.strictEqual(result.success, false);
+    assert.strictEqual(result.error, 'no db');
+  });
+});
+

front_end/panels/ai_chat/tools/__tests__/ReadFileTool.test.ts

@@ -0,0 +1,67 @@
+// Copyright 2025 The Chromium Authors
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+import {ReadFileTool} from '../ReadFileTool.js';
+import {FileStorageManager, type StoredFile} from '../FileStorageManager.js';
+
+describe('ReadFileTool', () => {
+  afterEach(() => {
+    sinon.restore();
+  });
+
+  function makeStored(overrides: Partial<StoredFile> = {}): StoredFile {
+    const now = Date.now();
+    return {
+      id: 'id-1',
+      sessionId: 'sess-1',
+      fileName: 'note.txt',
+      content: 'hello',
+      mimeType: 'text/plain',
+      createdAt: now - 100,
+      updatedAt: now,
+      size: 5,
+      ...overrides,
+    };
+  }
+
+  it('reads an existing file and returns metadata', async () => {
+    const stored = makeStored();
+    const fakeManager = {readFile: sinon.stub().resolves(stored)} as unknown as FileStorageManager;
+    sinon.stub(FileStorageManager, 'getInstance').returns(fakeManager);
+
+    const tool = new ReadFileTool();
+    const result = await tool.execute({fileName: 'note.txt', reasoning: 'inspect'});
+
+    assert.strictEqual(result.success, true);
+    assert.strictEqual(result.fileName, 'note.txt');
+    assert.strictEqual(result.content, 'hello');
+    assert.strictEqual(result.mimeType, 'text/plain');
+    assert.strictEqual(result.size, 5);
+    assert.isNumber(result.createdAt);
+    assert.isNumber(result.updatedAt);
+  });
+
+  it('returns a not found error when manager returns null', async () => {
+    const fakeManager = {readFile: sinon.stub().resolves(null)} as unknown as FileStorageManager;
+    sinon.stub(FileStorageManager, 'getInstance').returns(fakeManager);
+
+    const tool = new ReadFileTool();
+    const result = await tool.execute({fileName: 'missing.txt', reasoning: 'inspect'});
+
+    assert.strictEqual(result.success, false);
+    assert.strictEqual(result.error, 'File "missing.txt" was not found in the current session.');
+  });
+
+  it('returns an error when read fails', async () => {
+    const fakeManager = {readFile: sinon.stub().rejects(new Error('disk error'))} as unknown as FileStorageManager;
+    sinon.stub(FileStorageManager, 'getInstance').returns(fakeManager);
+
+    const tool = new ReadFileTool();
+    const result = await tool.execute({fileName: 'note.txt', reasoning: 'inspect'});
+
+    assert.strictEqual(result.success, false);
+    assert.strictEqual(result.error, 'disk error');
+  });
+});
+