Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

game over & paused modals offset the game formatting #31

Open
Broderick-Westrope opened this issue Dec 20, 2024 · 0 comments
Open

game over & paused modals offset the game formatting #31

Broderick-Westrope opened this issue Dec 20, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@Broderick-Westrope
Copy link
Owner

Image

As shown in the above image, the game over modal/popup badly interacts with the background content. This is likely due to bugs in my overlay util. I'd like to fix it as part of Tetrigo though as it is a good example.

Image annotations:

  • 1-2) The content is in bold since the "Game Over" text behind was in bold. The same is true for the underline. Both of these are likely to do with overlaying text during the middle of an escape sequence. Ideally the overlay function would check the portion of each line it is overlaying for escape sequences and close them early. That is, for the Game Over bold and underline the escape sequences should be ended after the "G" that is visible.
  • 3-5) These horizontal misalignments are likely all due to the same cause. I am unsure what the cause is, but my first hunch is that fixing the previous point (escape sequence handling) may remove this issue. If not, it will require further investigation.

Sequin is a tool that was recently release that allows viewing/debugging ANSI escape sequences. It will prove useful for this task.

@Broderick-Westrope Broderick-Westrope moved this to Backlog in Tetrigo Dec 20, 2024
@Broderick-Westrope Broderick-Westrope added the bug Something isn't working label Dec 20, 2024
@Broderick-Westrope Broderick-Westrope moved this from Backlog to Ready in Tetrigo Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Ready
Development

No branches or pull requests

1 participant