Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: disallow host-context #13

Merged
merged 3 commits into from
Jul 22, 2022
Merged

Conversation

devpow112
Copy link
Contributor

@devpow112 devpow112 commented Jul 21, 2022

The host-context selector isn't supported by a number of the browsers we support as a company. Disallow it's use for now as we've had issues with it making it into production. Recommend viewing with white-space diff off as files were reformatted based on .editorconfig settings.

index.js Outdated Show resolved Hide resolved
@devpow112 devpow112 marked this pull request as ready for review July 21, 2022 13:46
@devpow112 devpow112 requested a review from a team as a code owner July 21, 2022 13:46
@devpow112 devpow112 requested a review from imcdonald-d2l July 21, 2022 14:01
Copy link
Member

@dlockhart dlockhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call, thanks Devon.

@devpow112 devpow112 merged commit 1cf2615 into main Jul 22, 2022
@devpow112 devpow112 deleted the depowell/disallow-host-context branch July 22, 2022 15:20
@ghost
Copy link

ghost commented Jul 22, 2022

🎉 This PR is included in version 0.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ghost ghost added the released label Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants