From 82f0dca78f2b9bb415293fc8f482fca44fafaf4c Mon Sep 17 00:00:00 2001 From: Dominic Hickie Date: Tue, 13 Aug 2024 09:59:36 +0100 Subject: [PATCH] Only configure publisher confirmation callbacks once during external bus initialisation --- src/Paramore.Brighter/CommandProcessor.cs | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/src/Paramore.Brighter/CommandProcessor.cs b/src/Paramore.Brighter/CommandProcessor.cs index 4a92d1c6f..f74e05274 100644 --- a/src/Paramore.Brighter/CommandProcessor.cs +++ b/src/Paramore.Brighter/CommandProcessor.cs @@ -172,8 +172,6 @@ public CommandProcessor(IAmARequestContextFactory requestContextFactory, _transformPipelineBuilder = new TransformPipelineBuilder(mapperRegistry, messageTransformerFactory); InitExtServiceBus(policyRegistry, outBox, outboxTimeout, producerRegistry, outboxBulkChunkSize); - - ConfigureCallbacks(producerRegistry); } /// @@ -220,8 +218,6 @@ public CommandProcessor(IAmASubscriberRegistry subscriberRegistry, _transformPipelineBuilder = new TransformPipelineBuilder(mapperRegistry, messageTransformerFactory); InitExtServiceBus(policyRegistry, outBox, outboxTimeout, producerRegistry, outboxBulkChunkSize); - - ConfigureCallbacks(producerRegistry); } /// @@ -261,8 +257,6 @@ public CommandProcessor(IAmASubscriberRegistry subscriberRegistry, _transformPipelineBuilder = new TransformPipelineBuilder(mapperRegistry, messageTransformerFactory); InitExtServiceBus(policyRegistry, outBox, outboxTimeout, producerRegistry, outboxBulkChunkSize); - - ConfigureCallbacks(producerRegistry); } /// @@ -815,8 +809,7 @@ private void AssertValidSendPipeline(T command, int handlerCount) where T : c $"No command handler was found for the typeof command {typeof(T)} - a command should have exactly one handler."); } - - private void ConfigureCallbacks(IAmAProducerRegistry producerRegistry) + private static void ConfigureCallbacks(IAmAProducerRegistry producerRegistry) { //Only register one, to avoid two callbacks where we support both interfaces on a producer foreach (var producer in producerRegistry.Producers) @@ -871,6 +864,8 @@ private static void InitExtServiceBus( _bus.PolicyRegistry = policyRegistry; _bus.ProducerRegistry = producerRegistry; _bus.OutboxBulkChunkSize = outboxBulkChunkSize; + + ConfigureCallbacks(producerRegistry); } } }