-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TSV/CSV Conversion Should Default to relaxed
mode
#97
Comments
As per the updated JSON validation we get an error like this
But here it should report the error in USFM. Shall work on that. But I dont know if defaulting to relaxed mode for all TSV/CSV conversion is a good idea. As the relaxed mode may accept incorrect usages and give incorrect data, I feel the user should choose that explicitly, other wise we should use, the stricter, normal mode, ensuring correctness of data we extract. |
The above error was shown because the USFM had errors. Changed this flow now. It checks if the USFM to JSON converson was successfull before passing it on to the toCSV() or toTSV(). Now the output, error report will be as follows
|
We will leave the decision to the user whether to use |
When converting to TSV and CSV mode from the command line the same USFM file errors out when trying to convert to TSV or CSV except when using the option
-l relaxed
. I think we should default torelaxed
mode whenever the user just wants to convert to TSV or CSV. Specifically I was trying to parse 01-GEN.usfm from here file.Also, I think we should find out why some of those files won't parse. On the command line I just see this:
Maybe report filename at least?
The text was updated successfully, but these errors were encountered: