Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error message seems to have wrong line number #81

Closed
RobH123 opened this issue Aug 17, 2020 · 3 comments
Closed

Error message seems to have wrong line number #81

RobH123 opened this issue Aug 17, 2020 · 3 comments
Assignees
Labels

Comments

@RobH123
Copy link

RobH123 commented Aug 17, 2020

Hi there,
I'm trying to check this and getting an error on line 62:

Line 62, col 19:
61 | \w וַ⁠יִּשְׂא֣וּ|lemma="נָשָׂא" strong="c:H5375" x-morph="He,C:Vqw3mp"\w* 
62 | \w לָ⁠הֶ֗ם|lemma="" strong="l" x-morph="He,R:Sp3mp"\w* 
                         ^ 
63 | \w נָשִׁים֙|lemma="אִשָּׁה" strong="H0802" x-morph="He,Ncfpa"\w* 
Expected not "\""

But that doesn't seem to match the lines in the file (and so I can't actually be sure what it's failing on)??? (You can also see it here and here.)

@kavitharaju
Copy link
Collaborator

The reason for the error is that there is an empty attribute. Lemma attribute is mentioned, but there is not value in it.

\w לָ⁠הֶ֗ם|lemma="" strong="l" x-morph="He,R:Sp3mp"\w*

The line number in error message says 62, but actually the line is 67. The reason for this difference is that, there are empty lines present in the file, which the parser eliminated while normalizing.

@RobH123
Copy link
Author

RobH123 commented Aug 17, 2020

Thanks for the fast response and pointing out the issues. I guess I can write code in my app to count the blank lines above the error line and then add that number to the given line number. But of course, the best place to do that would be inside this package.

@joelthe1
Copy link
Collaborator

Yes, we will update the tool to report meaningful line numbers for errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants