US / Imperial quart ("qt") conversion is treated as pints instead

[SureshotM6]

Seen in version 4.0.15.

Brewtarget is improperly converting 8 quarts to 1 gallon instead of 4 quarts to 1 gallon. Additionally, the conversion between quarts and Metric units are incorrect. It seems that "qt" is incorrectly converted to pints ("pt") instead.

This is easiest to reproduce using the "Converter Tool". The following conversion from gallons to quarts should show "4.000 qt" instead of "8.000 qt" (for both US and Imperial):

The following conversion from 1qt (US) to liters should show 0.946 L, but instead shows "0.568 L":

That conversion is actually broken for 2 reasons:

1. This matches an Imperial pint (0.568 L), not quart (1.137 L)
2. My units are set to US, so it shouldn't be using Imperial anyway (I'll open a separate issue for that).

This seems that it may have been broken since commit 3a95a7f (v3.0.5) based on a cursory code inspection. That commit added pints, but labeled them as "qt" instead of "pt" which is likely what caused the breakage. I'd be happy to fix this myself when I have time, but it would likely be faster for someone else to make this change.

[matty0ung]

Thanks for letting me know about this -- and for giving such good detail. I'll do a fix.

[matty0ung]

Fix included in 4.0.16 release.