iOS - Builds still failing (2.0.5) #73
Comments
|
@gabaum10 I guess npm update with fix wasn't released yet. FIx for your issue would be goto |
|
I would if I could, but I've switched over to building through Intel XDK because I don't have access to a mac. Modifying the plugin source files currently is not supported by them. It pulls the files fresh from NPM every build. I have to wait until the fix is pushed there. I could have sworn @aaustin said it was fixed in #71, but it's stil not working. The version in NPM is 2.0.5 as per: https://www.npmjs.com/package/branch-cordova-sdk |
|
I definitely fixed the header so that it'd be |
|
Deployed again, with the header definitely changed. I have to change it back before committing since we're using the framework for the git repo. |
|
I verified the code being sent with the build. That now looks right. Unfortunately, there are a bunch of other errors now. Does this actually work when you guys test it? Am I doing something wrong? I see two errors now: CompileC build/Veoci\ -\ DEV.build/Release-iphoneos/Veoci\ -\ DEV.build/Objects-normal/armv7/BranchSDK.o Veoci\ -\ DEV/Plugins/io.branch.sdk/BranchSDK.m normal armv7 objective-c com.apple.compilers.llvm.clang.1_0.compiler CompileC build/Veoci\ -\ DEV.build/Release-iphoneos/Veoci\ -\ DEV.build/Objects-normal/armv7/AppDelegate+BranchSdk.o Veoci\ -\ DEV/Plugins/io.branch.sdk/AppDelegate+BranchSdk.m normal armv7 objective-c com.apple.compilers.llvm.clang.1_0.compiler |
|
Looks like there were some hidden spots. Try again? I went through all files now. |
|
Now I'm getting a different error that does not happen if I exclude the plugin: Ld build/Veoci\ -\ DEV.build/Release-iphoneos/Veoci\ -\ DEV.build/Objects-normal/armv7/Veoci\ -\ DEV normal armv7 ** BUILD FAILED ** Looking around, it seems this is because of the way some of the files are linked? I have never seen this before, but I'm building via CLI-5.1.1. Is that not supported by this plugin? Not sure if this SO answer helps or not. I personally have no depth here so I can't be of much help. |
|
So, with the update, we required CoreSpotlight.framework. I've asked our contractors to attempt to bundle this into the npm install process, but they haven't done this yet. Can you try added it it/ |
|
I have no idea how to do that. Like I mentioned before, I'm out of my depth here. I was just hoping to use the plugin for the end goal. I guess I'll just wait for the real fix to go out. Sorry I'm not more helpful fixing this stuff. Some day I'll learn more about the actual cordova process. |
|
@aaustin I noticed these frameworks listed in docs, but wasn't sure if the documentation was accurate as the functionality was working without adding them. https://dev.branch.io/getting-started/sdk-integration-guide/advanced/ios/#install-the-sdk-manually |
|
So this actually builds using cli-6.0.0, but not cli-5.1.1. I assume cli-6.0 includes the necessary dependencies as part of the cordova base package. For policy reasons, I can't use 6.0.0 at the moment. That's why I am hoping you could package up any dependencies in the package so cli-5.1.1 could be used for production. |
|
I reverted back to my old build process using PGB for now since that supports cli-6.0.0. I still think packaging up the dependencies would be a good improvement, but not strictly speaking blocking for me at least. Now if I could only figure out how to get universal links working... |
|
@gabaum10 I'm trying to replicate the issue. But when I use v5.1.1, nothing happens upon building the app. Could you provide some steps on replicating the issue? |
|
@gabaum10 , could you try this solution? |
|
I just switched over to cli-6.0.0. It's building fine with that and I'm not going to fight it anymore. I was building on Phonegap build using the |
|
I'm using Cordova 6.1, but this error still occurs: |
|
I'm getting this as well. Could it be due to the new release? |
|
@bjornbos @qimingfang , |
|
Hey @qimingfang - The above issue was resolved. You're getting the |
|
@aaustin i'm also getting I added this through the github link in the README. Didn't realize there was an npm for this. Is this the one? https://tonicdev.com/npm/branch-cordova-sdk |
|
Yessir - that's the one. I believe I found your issue, which was a result of me deploying to NPM earlier but not updating the plugin.xml. I've just resolved the github plugin.xml here: 0a8ccb0 |
|
oh, thanks @aaustin , will re-close the issue now. |
|
thanks @aaustin! your fix worked well :) are you planning on bumping the patch version for this fix and upload a new version onto npm? |
|
The NPM version is working fine as far as I can tell. I had just mangled the Github one :( |
Guys, my builds are still failing. I thought this issue was fixed? I'm using version 2.0.5 from NPM.
CompileC build/Veoci\ -\ DEV.build/Release-iphoneos/Veoci\ -\ DEV.build/Objects-normal/armv7/BranchSDK.o Veoci\ -\ DEV/Plugins/io.branch.sdk/BranchSDK.m normal armv7 objective-c com.apple.compilers.llvm.clang.1_0.compiler
cd .../builds/build.2016-03-17.09-43-01.wWaLGO.tmp/Veoci_Dev/platforms/ios
export LANG=en_US.US-ASCII
export PATH="/Applications/Xcode.app/Contents.../Platforms/iPhoneOS.platform.../usr/bin:/Applications/Xcode.app/Contents.../usr/bin:/usr/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/tools:/platform-tools"
/Applications/Xcode.app/Contents.../Toolchains/XcodeDefault.xctoolchain/usr/bin/clang -x objective-c -arch armv7 -fmessage-length=0 -fdiagnostics-show-note-include-stack -fmacro-backtrace-limit=0 -std=c99 -fobjc-arc -gmodules -Wno-trigraphs -fpascal-strings -Os -Wno-missing-field-initializers -Wno-missing-prototypes -Wno-implicit-atomic-properties -Wno-arc-repeated-use-of-weak -Wduplicate-method-match -Wno-missing-braces -Wparentheses -Wswitch -Wunused-function -Wno-unused-label -Wno-unused-parameter -Wunused-variable -Wunused-value -Wempty-body -Wuninitialized -Wno-unknown-pragmas -Wno-shadow -Wno-four-char-constants -Wno-conversion -Wconstant-conversion -Wint-conversion -Wbool-conversion -Wenum-conversion -Wno-shorten-64-to-32 -Wpointer-sign -Wno-newline-eof -Wno-selector -Wno-strict-selector-match -Wundeclared-selector -Wno-deprecated-implementations -isysroot /Applications/Xcode.app/Contents.../Platforms/iPhoneOS.platform.../SDKs/iPhoneOS9.2.sdk -fstrict-aliasing -Wprotocol -Wdeprecated-declarations -miphoneos-version-min=8.0 -g -fvisibility=hidden -Wno-sign-conversion -iquote .../builds/build.2016-03-17.09-43-01.wWaLGO.tmp/Veoci_Dev/platforms/ios/build/Veoci\ -\ DEV.build/Release-iphoneos/Veoci\ -\ DEV.build/Veoci\ -\ DEV-generated-files.hmap -I.../builds/build.2016-03-17.09-43-01.wWaLGO.tmp/Veoci_Dev/platforms/ios/build/Veoci\ -\ DEV.build/Release-iphoneos/Veoci\ -\ DEV.build/Veoci\ -\ DEV-own-target-headers.hmap -I.../builds/build.2016-03-17.09-43-01.wWaLGO.tmp/Veoci_Dev/platforms/ios/build/Veoci\ -\ DEV.build/Release-iphoneos/Veoci\ -\ DEV.build/Veoci\ -\ DEV-all-target-headers.hmap -iquote .../builds/build.2016-03-17.09-43-01.wWaLGO.tmp/Veoci_Dev/platforms/ios/build/Veoci\ -\ DEV.build/Release-iphoneos/Veoci\ -\ DEV.build/Veoci\ -\ DEV-project-headers.hmap -I.../builds/build.2016-03-17.09-43-01.wWaLGO.tmp/Veoci_Dev/platforms/ios/build/device/include -I.../builds/build.2016-03-17.09-43-01.wWaLGO.tmp/Veoci_Dev/platforms/ios/build/device/usr/local/lib/include -I.../builds/build.2016-03-17.09-43-01.wWaLGO.tmp/Veoci_Dev/platforms/ios/build/UninstalledProducts/include -I.../builds/build.2016-03-17.09-43-01.wWaLGO.tmp/Veoci_Dev/platforms/ios/build/device -I.../builds/build.2016-03-17.09-43-01.wWaLGO.tmp/Veoci_Dev/platforms/ios/build/Veoci\ -\ DEV.build/Release-iphoneos/Veoci\ -\ DEV.build/DerivedSources/armv7 -I.../builds/build.2016-03-17.09-43-01.wWaLGO.tmp/Veoci_Dev/platforms/ios/build/Veoci\ -\ DEV.build/Release-iphoneos/Veoci\ -\ DEV.build/DerivedSources -F.../builds/build.2016-03-17.09-43-01.wWaLGO.tmp/Veoci_Dev/platforms/ios/build/device -include .../builds/build.2016-03-17.09-43-01.wWaLGO.tmp/Veoci_Dev/platforms/ios/build/sharedpch/Veoci\ -\ DEV-Prefix-aooswzgffdjakkabtibdsuigiqoe/Veoci\ -\ DEV-Prefix.pch -MMD -MT dependencies -MF .../builds/build.2016-03-17.09-43-01.wWaLGO.tmp/Veoci_Dev/platforms/ios/build/Veoci\ -\ DEV.build/Release-iphoneos/Veoci\ -\ DEV.build/Objects-normal/armv7/BranchSDK.d --serialize-diagnostics .../builds/build.2016-03-17.09-43-01.wWaLGO.tmp/Veoci_Dev/platforms/ios/build/Veoci\ -\ DEV.build/Release-iphoneos/Veoci\ -\ DEV.build/Objects-normal/armv7/BranchSDK.dia -c .../builds/build.2016-03-17.09-43-01.wWaLGO.tmp/Veoci_Dev/platforms/ios/Veoci\ -\ DEV/Plugins/io.branch.sdk/BranchSDK.m -o .../builds/build.2016-03-17.09-43-01.wWaLGO.tmp/Veoci_Dev/platforms/ios/build/Veoci\ -\ DEV.build/Release-iphoneos/Veoci\ -\ DEV.build/Objects-normal/armv7/BranchSDK.o
In file included from .../builds/build.2016-03-17.09-43-01.wWaLGO.tmp/Veoci_Dev/platforms/ios/Veoci - DEV/Plugins/io.branch.sdk/BranchSDK.m:8:
.../builds/build.2016-03-17.09-43-01.wWaLGO.tmp/Veoci_Dev/platforms/ios/Veoci - DEV/Plugins/io.branch.sdk/BranchSDK.h:8:9: fatal error: 'Branch/Branch.h' file not found
import <Branch/Branch.h>
1 error generated.
The text was updated successfully, but these errors were encountered: