Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contentMetaData doesn't seem to be appearing in the data when the user clicks the link #54

Closed
tkuben opened this issue Mar 3, 2016 · 4 comments

Comments

@tkuben
Copy link

tkuben commented Mar 3, 2016

Hi,

I created the Branch Universal Object using the following params:

var universalObjParams = {canonicalIdentifier: 'identifier',
                                      title: 'title',
                                      contentDescription: '',
                                      contentImageUrl: '',
                                      contentIndexingMode: 'public', 
                                      contentMetadata: {testData: 'some test data'}};

However, when the user clicks on the link based on this universal object, the data that gets into DeepLinkHandler does not contain the metaData "testData". How can I add additional data sets to a tracking link?

Based on the code base, it doesn't seem like there is anything being done with the contentMetaData:

https://github.com/BranchMetrics/Cordova-Ionic-PhoneGap-Deferred-Deep-Linking-SDK/blob/master/src/android/io/branch/BranchSDK.java#L377

Thoughts?

TJ

@tkuben
Copy link
Author

tkuben commented Mar 3, 2016

Hi,

I believe in:
https://github.com/BranchMetrics/Cordova-Ionic-PhoneGap-Deferred-Deep-Linking-SDK/blob/master/src/android/io/branch/BranchSDK.java#L377

You should probably add a call to:

https://github.com/BranchMetrics/Android-Deferred-Deep-Linking-SDK/blob/master/Branch-SDK/src/io/branch/indexing/BranchUniversalObject.java#L173

Attached File: contentMetaDataFixPatch.diff.txt

Please see the attached patch file which fixes the issue for me. The link generated using the compiled code had the contentMetaData when the user clicked and returned to the app.

Cheers,
TJ

@tkuben
Copy link
Author

tkuben commented Mar 3, 2016

Please make the appropriate fix to the ios codebase as well.

@aaustin
Copy link
Contributor

aaustin commented Mar 3, 2016

Hi @tkuben - I've just merged this to master and will do a deploy to NPM later today.

@aaustin aaustin closed this as completed Mar 3, 2016
@tkuben
Copy link
Author

tkuben commented Mar 10, 2016

Hi @aaustin

Does the ios side of the SDK need a similar fix? I just opened a new issue for the IOS: #62. The data does not seem to be coming through when someone clicks on an ios device.

Thanks,
TJ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants