Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query Parameter getting stripped off #322

Closed
gabaum10 opened this issue May 1, 2017 · 4 comments
Closed

Query Parameter getting stripped off #322

gabaum10 opened this issue May 1, 2017 · 4 comments

Comments

@gabaum10
Copy link

gabaum10 commented May 1, 2017

I have a URL coming in through an email with the scheme like this:

<themename>/447/?thread=pv8wivm9gy-40587

When the url gets to the app in the data.deeplink_path in the window.DeepLinkHandler, the query parameter is missing. This used to work, but I recently updated and it seems to have broken.

URLs without the query parameters work fine.

@gabaum10
Copy link
Author

gabaum10 commented May 1, 2017

I just verified testing via the smart banner as well. The data passed to the deelink_path is correct. The query param is getting lost somewhere internally in the plugin as far as I can tell...

@gabaum10
Copy link
Author

gabaum10 commented May 1, 2017

Thinking perhaps it was because I was using the legacy window.DeepLinkHandler, I updated my code to use the initSession(data) function instead. I also updated to the latest version of the plugin (2.5.16). None of that seemed to help the issue.

@ethanneff
Copy link
Contributor

Hello again,

I have done the following tests with successful opening and passing of data into the app:

Can you please provide me with some more information about how you are testing so I can simulate the issue on my end? Specifically, the steps including the deep link you are clicking, the data you want to pass, the device you are using, and any relevant Branch code within your app.

Thanks,

@gabaum10
Copy link
Author

gabaum10 commented May 3, 2017

Sorry, I just saw this. I bizarrely didn't get a notification...

I realized it was something we were doing. We were trying to pass the raw web URL into the app via the deeplink_path parameter, but we weren't passing the query string in! That's why it wasn't there.

@gabaum10 gabaum10 closed this as completed May 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants