Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update plugin.xml id to be consistent with npm #290

Closed
djett41 opened this issue Mar 3, 2017 · 3 comments
Closed

Update plugin.xml id to be consistent with npm #290

djett41 opened this issue Mar 3, 2017 · 3 comments

Comments

@djett41
Copy link

djett41 commented Mar 3, 2017

right now your npm id is branch-cordova-sdk but the plugin id is io.branch.sdk. As a result, you have to add the plugin using branch-cordova-sdk but you have to remove the plugin using the plugin.xml id which is io.branch.sdk.

These id's should be consistent so theres no issues using the Cordova CLI

@ethanneff
Copy link
Contributor

Hello,

I apologize for this, we are using semantic release for our versioning and it is not properly updating our package.json and plugin.xml. I have just pushed a new update to the SDK with theses values manually changed.

I will look into what went wrong and hopefully automate this process in the future.

I apologize for the inconvenience this may have caused.

Thanks,

@ethanneff
Copy link
Contributor

Hello @djett41,

I have made the following code modification so this error should not happen in the future:
98139de, 3b0c9cc, 5071dcb

Whenever you are importing Branch, be sure to add the spec field so you pull in the correct version:

exact: <plugin name="branch-cordova-sdk" spec="2.5.0" />
major+: <plugin name="branch-cordova-sdk" spec="^2.5.0" />
minor+: <plugin name="branch-cordova-sdk" spec="~2.5.0" />

Thank you for bringing this to our attention.

Best,

@djett41
Copy link
Author

djett41 commented Mar 7, 2017

awesome thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants