-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config.xml branch-config doesnt support multiple associated-domains #277
Comments
hey @djett41 , |
Thanks for the quick reply @renesansz. These are actually different. This issue has to do with the AndroidManifest.xml while the other has to do with the ios .entitlements file. In my example I would like for my AndroidManifest.xml to have multiple intent-filters
In this case I would want to have a config.xml with the following
or something that allows me to supply more than one branch config. Currently, the plugin will only add the first one to the AndroidManifest.xml |
Hello @djett41, Thank you for reaching out. The I will be closing this ticket. Feel free to reach out to Branch Support if you have specific questions regarding your Branch account. |
@ethanneff Thanks for the quick reply. We have a bnc.lt domain and an app.link domain. All new links use the app.link, but some old links from bnc.lt are still live. Just to confirm, do we only need to include the bnc.lt link domain in the android-prefix and not the app.link? |
@ethanneff why did you close this?
That is still true, it is not possible to define any other associated domain beside the |
Hello @smaspe, You can now have multiple link domains: 0f90b3e Please update to the latest Branch SDK to take advantage of this update. docs <!-- sample config.xml -->
<widget id="com.eneff.branch.cordovatestbed" version="1.0.0" xmlns="http://www.w3.org/ns/widgets" xmlns:cdv="http://cordova.apache.org/ns/1.0">
<!-- Branch -->
<plugin name="branch-cordova-sdk" spec="~2.4.2" /> <!-- optional spec -->
<branch-config>
<branch-key value="key_live_ndqptlgXNE4LHqIahH1WIpbiyFlb62J3" />
<uri-scheme value="branchcordova" />
<link-domain value="yourcustomdomain.com" />
<link-domain value="cordova.app.link" /> <!-- optional previous link domain -->
<link-domain value="bnc.lt" /> <!-- optional previous link domain -->
<ios-team-release value="PW4Q8885U7" />
<ios-team-debug value="FG35JLLMXX" /> <!-- optional -->
<android-prefix value="/WSuf" /> <!-- optional (for bnc.lt) -->
<android-testmode value="true" /> <!-- optional (simulate installs) -->
</branch-config> Best, |
@ethanneff cool thanks! |
I have a requirement for multiple deep links and need to add multiple in my config.xml, in which I want multiple intent-filter's to be generated in the AndroidManifest.xml with different schemes/hosts/prefix's.
Currently if I define multiple branch-config elements, only the first one wins, and the entitlements file only shows the first one, as well as only one intent-filter.
This plugin should support multiple branch configuration. Thanks!
The text was updated successfully, but these errors were encountered: