Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect doc property #272

Closed
NorthMcCormick opened this issue Jan 14, 2017 · 2 comments
Closed

Incorrect doc property #272

NorthMcCormick opened this issue Jan 14, 2017 · 2 comments

Comments

@NorthMcCormick
Copy link

Hello,

It looks like that in the example for creating a UC object the property 'contentIndexingMode' is being used but I'm pretty sure it should be 'contentIndexMode' as per the other half of the doc.

It was just confusing until I realized it. If it's correct then can we get an explanation why?
@renesansz
Copy link
Contributor

renesansz commented Jan 16, 2017 •
edited
Loading

@NorthMcCormick ,
I apologize for the confusion, I've looked into the native source code, it should be contentIndexingMode. Submitted PR #273 to fix the typo.

@ethanneff
Copy link
Contributor

@NorthMcCormick Thank you for finding this issue with the docs. The docs have been updated.

@renesansz Thank you for making your pull request. It has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ethanneff @NorthMcCormick @renesansz