Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is onNonBranchLink() usable? #269

Closed
chanphillip opened this issue Dec 30, 2016 · 4 comments
Closed

Is onNonBranchLink() usable? #269

chanphillip opened this issue Dec 30, 2016 · 4 comments

Comments

@chanphillip
Copy link

As the doc does not mention onNonBranchLink() and NonBranchLinkHandler() seems to be depreciated, I would like to ask if onNonBranchLink() is usable?
I've tried using it but the behavior is a little strange. It will be fired every onResume no matter if the app is opened through a deeplink (i.e. appname://).

If onNonBranchLink() is not suppose to be used, what should be the way to handle non-branch deeplinks? Perhaps using another plugin?

@renesansz
Copy link
Contributor

@chanphillip you can look in to this part of the doc on how to handle non-universal link.

@ethanneff
Copy link
Contributor

Hello @chanphillip,

Ideally, onNonBranchLink() should never be called. This is a method to handle URI Schemes from other Cordova plugins which can interact with Branch URI Schemes.

When clicking on a Branch deep link, all deep link data should be retreived from the Branch.initSession(function(data) callback regardless of resume or deviceready:

Branch.initSession(function(data) {
  // read deep link data on click
  alert('Deep Link Data: ' + JSON.stringify(data));
});

Where you relying on the depreciated NonBranchLinkHandler() before? If so, I would like to know more (the steps, the use case, etc). It could be possible that the new onNonBranchLink() is not functioning correctly.

Best,

@jstoup111
Copy link

@ethanneff onNonBranchLink() was added as a request by me.

I needed to Deep Links that were not Branch links. I.E. my-scheme://home instead of something that Branch generated.

@chanphillip is asking how to use this SDK while still being able to send non branch deep links to his application.

@ethanneff
Copy link
Contributor

@chanphillip I am closing this ticket, feel free to reach out if you are still experiencing issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants