Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to install the plugin in Platforms directory using config.xml #251

Closed
adityasaxena opened this issue Dec 7, 2016 · 3 comments
Closed

Comments

@adityasaxena
Copy link

Hi,

In my config.xml I have two things:

<plugin name="io.branch.sdk" spec="~2.4.2">
        <variable name="BRANCH_KEY" value="key_live_igupHQAeyeHaILjCyCPGajcayDjCyCPG" />
        <variable name="URI_SCHEME" value="XXX" />
    </plugin>
<branch-config>
        <host name="XXX.app.link" scheme="https" />
    </branch-config>

When I try to do cordova build android, the plugin doesn't result in my AndroidManifest.xml changes.

However, if I tried to do cordova plugin add ... command, then the plugin does get added to AndroidManifest.xml.

Could someone help me understand what am I missing here ?

@renesansz
Copy link
Contributor

renesansz commented Dec 7, 2016

@aditiverma ,
<branch-config> is okay, however can you try to set your branch_key & uri_scheme upon adding the plugin?

cordova plugin add branch-cordova-sdk --variable BRANCH_KEY=<YOUR-BRANCH-KEY> --variable URI_SCHEME=<YOUR-URI-SCHEME>;

@adityasaxena
Copy link
Author

adityasaxena commented Dec 7, 2016

@renesansz I can't believe what I have for you :-) io-branch-sdk cannot fetch the plugin from registry when set like this:

<plugin name="io.branch.sdk" spec="~2.4.2">
        <variable name="BRANCH_KEY" value="key_live_igupHQAeyeHaILjCyCPGajcayDjCyCPG" />
        <variable name="URI_SCHEME" value="XXX" />
    </plugin>

The above however is what happens when you do cordova plugin add branch-cordova-sdk --variable BRANCH_KEY=<YOUR-BRANCH-KEY> --variable URI_SCHEME=<YOUR-URI-SCHEME>; Yes, the plugin name in config.xml is set to be io.branch.sdk. Maybe because that is what is set in plugin.xml

What does work however is this:

<plugin name="branch-cordova-sdk" spec="~2.4.2">
        <variable name="BRANCH_KEY" value="key_live_igupHQAeyeHaILjCyCPGajcayDjCyCPG" />
        <variable name="URI_SCHEME" value="XXX" />
    </plugin>

Would someone have this fixed soon ? :-)

@adityasaxena
Copy link
Author

I don't think any progress will be made here. I am making my way by using branch-cordova-sdk in the plugin's name field and that lets me move forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants