Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Campaign field in analytics cannot be set #247

Closed
XavierMelladoAtIncubapps opened this issue Dec 5, 2016 · 3 comments
Closed

Campaign field in analytics cannot be set #247

XavierMelladoAtIncubapps opened this issue Dec 5, 2016 · 3 comments

Comments

@XavierMelladoAtIncubapps
Copy link

XavierMelladoAtIncubapps commented Dec 5, 2016

Hi!

When I build a link, I set the campaign value in analytics to a given value. But, when I use the link, this field is always empty, no matter what I initially set. I think this issue is related to #162.

For us, not setting the campaign is a real show stopper. Please, can anyone help me? Am I doing something wrong or has the Cordova plugin a bug?

Thanks in advance,
Xavi

I am using Ionic 2 Beta 11. This is my system information:

Cordova CLI: 6.3.1
Ionic Framework Version: 2.0.0-beta.11
Ionic CLI Version: 2.0.0-beta.37
Ionic App Lib Version: 2.0.0-beta.20
ios-deploy version: 1.9.0 
ios-sim version: 5.0.11 
OS: Mac OS X El Capitan
Node Version: v4.6.2
Xcode version: Xcode 8.1 Build version 8B62 

I am using the latest version of the plugin:

<plugin name="io.branch.sdk" spec="~2.4.2">

@renesansz
Copy link
Contributor

Hey @XavierMelladoAtIncubapps ,
Thanks for reporting, It seems the campaign field was not implemented in the Cordova plugin yet.
I'll submit a PR soon and hopefully will resolve this issue.

Cheers,

@renesansz
Copy link
Contributor

submitted PR #249 to address this issue

@ethanneff
Copy link
Contributor

fixed in #255.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants