Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enterring floats ending on .0 in the frontend returns integer value to the backend #78

Closed
rtaaning opened this issue Jun 22, 2021 · 2 comments · Fixed by #91
Closed
Assignees
Labels
bug Something isn't working help wanted Extra attention is needed
Milestone

Comments

@rtaaning
Copy link

Enterring float range between 0.0 and 1.0 gives wrong performance on "next experiment", only returning integer values:

image

Enterring float range between 0.1 and 1.1 gives expected performance on "next experiment":

image

@langdal langdal added the bug Something isn't working label Jun 22, 2021
@dk-teknologisk-mon
Copy link

I would probably suggest that when a solution is implemented, it is done in such a fashion that the user has to specify whether a variable is continuous or discrete, with continuous being the default choice, that gets applied unless you actively do something. It would seem natural to most people to enter min/max values as whole numbers in very many cases, without the implication that they are discrete integers. This is also how this choice is dealt with In classical DOE software, such as Design Expert:
image

@dk-teknologisk-mon dk-teknologisk-mon added the help wanted Extra attention is needed label Jun 25, 2021
@rtaaning rtaaning reopened this Jun 28, 2021
@langdal
Copy link
Member

langdal commented Jul 1, 2021

Having looked a bit into the code the proper solution seems to be in line with the suggestion from @dk-teknologisk-mon
We suggest to add an input type to the "Add variable" dialog like in this mock-up
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants