Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sidebar collapse button to sidebar while viewing the tags list #3239

Merged
merged 1 commit into from
Sep 14, 2019

Conversation

robbawebba
Copy link
Contributor

Description

The sidebar contains a button to collapse the sidebar, but it is only visible when viewing the list of storages and notes. If the user is currently viewing the list of tags, the sidebar collapse button is not visible:
image

Notes view has always shown the sidebar collapse button:
image

The tags list now renders the sidebar collapse button as well:
image

Issue fixed

Fixes #2097

Type of changes

  • 🔘 Bug fix (Change that fixed an issue)
  • ⚪ Breaking change (Change that can cause existing functionality to change)
  • ⚪ Improvement (Change that improves the code. Maybe performance or development improvement)
  • ⚪ Feature (Change that adds new functionality)
  • ⚪ Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

  • 🔘 My code follows the project code style
  • ⚪ I have written test for my code and it has been tested
  • 🔘 All existing tests have been passed
  • 🔘 I have attached a screenshot/video to visualize my change if possible

@Flexo013 Flexo013 added the awaiting review ❇️ Pull request is awaiting a review. label Sep 4, 2019
@Flexo013
Copy link
Contributor

Flexo013 commented Sep 4, 2019

Thanks for your contribution! This PR will be reviewed by @ZeroX-DG or @Rokt33r.

Copy link
Member

@ZeroX-DG ZeroX-DG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@ZeroX-DG ZeroX-DG added approved 👍 Pull request has been approved by sufficient reviewers. and removed awaiting review ❇️ Pull request is awaiting a review. labels Sep 6, 2019
@Rokt33r Rokt33r merged commit 68175cd into BoostIO:master Sep 14, 2019
@Rokt33r Rokt33r removed the approved 👍 Pull request has been approved by sufficient reviewers. label Sep 14, 2019
@Rokt33r Rokt33r added this to the v0.13.0 milestone Sep 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Control to collapse sidebar disappears in tag list mode
4 participants