-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scroll Bars can now be hidden #2713
Conversation
Can you fix the conflict? I think you don't need to restart the app to see the effect. To disable editor scroll bar you can apply the style to the editor component. And for the preview, we can apply the style and call the rewrite function to cause the preview to re-write. I haven't tested it yet but what do you think? |
Ok, I will look into that |
Is this feature no longer available? I wasn't able to find it in v0.13.0 (0.13.0). |
@suefeng This feature was never merged into the main project. @gregueiras Could you fix the conflicts then we can merge this. |
Hi @Flexo013, I think I've fixed all conflicts 😃 I had another PR, that never got merged, if you could look into it it would be awesome, it allowed users to set a simple theme scheduler |
@gregueiras sorry for the wait, can you resolve the conflict again please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
Might be related to #3486 |
Description
Users can now hide the scroll bars in the editor and in the markdown preview
Issue fixed
Issue #2174 make scroll bars visibility optional?
Type of changes
Checklist: