-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better scroll sync between the editor and the preview in the SplitEditor #2405
Conversation
…he SplitEditor (particularly with lot of images)
- support checkbox preference `When scrolling, synchronize preview with editor`
I've tested it with the preferences It's working fine. |
Would love to see this be added, its really hard to navigate when viewing side by side due to inconsistency between the live preview and the text itself |
Was this pr abandoned? |
@Aaron-Bird not by me 😉 |
Sorry for not being able to review this soon, I'll try to work on this when I have time. |
is there any update for this pr? |
@daiyam sorry for the wait, can you resolve conflict for this PR please? |
@ZeroX-DG I've resolved the conflicts |
@daiyam the feature does work well but one bug that I found is if you don't separate the lines with an empty line. The whole thing will be rendered as a paragraph with each line separate with |
@ZeroX-DG I've pushed a fix. Can you test it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool, I think everything looks good now 🎉
@daiyam i Think that this pull request is still maintained after almost 2 years deserves some mention. 😮 |
Description
This change implements better positioning between the editor and the preview in the SplitEditor (particularly with lot of images).
When scrolling, it calculates the position of the shown block (at 1/3 below the top) based on the previous blocks' heights.
When the cursor is active, the preview is moved at a position so we can see what we are typing.
Issue fixed
Type of changes
Checklist:
IssueHunt Summary
Referenced issues
This pull request has been submitted to: