Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note counter bug #1894

Closed
yasuokav opened this issue May 9, 2018 · 8 comments · Fixed by #1895
Closed

Note counter bug #1894

yasuokav opened this issue May 9, 2018 · 8 comments · Fixed by #1895
Labels
bug 🐛 Issue concerns a bug.

Comments

@yasuokav
Copy link

yasuokav commented May 9, 2018

Current behavior

Storage1
 - Default : 0
 - Notebook1 : 2
Storage2
 - Notebook2 : 0

Expected behavior

Storage1
 - Default : 0
 - Notebook1 : 1
Storage2
 - Notebook2 : 0

Steps to reproduce

Storage1
 - Default : 0
 - Notebook1 : 1 (Note1)
Storage2
 - Notebook2 : 0
  1. Open "All Notes"
  2. Create a new note
Storage1
 - Default : 1 (Note2)
 - Notebook1 : 1 (Note1)
Storage2
 - Notebook2 : 0
  1. Move Note1 to Storage2:Notebook2
Storage1
 - Default : 1 (Note2)
 - Notebook1 : 0 
Storage2
 - Notebook2 : 1 (Note1)
  1. Move back to Storage1:Notebook1
Storage1
 - Default : 1 (Note2)
 - Notebook1 : 2 (Note1)  (Bug here)
Storage2
 - Notebook2 : 0
  1. Delete Note2
Storage1
 - Default : 0
 - Notebook1 : 1 (Note1)
Storage2
 - Notebook2 : 0
  1. Empty Trash
Storage1
 - Default : 0
 - Notebook1 : 2 (Note1)  (Bug here)
Storage2
 - Notebook2 : 0
  1. Click Notebook1
    Error:
    Uncaught TypeError: Cannot read property 'isPinned' of undefined

Environment

  • Version : 0.11.4
  • OS Version and name : Windows 10 x64

Please check this line. I'm not sure, though.
https://github.com/BoostIO/Boostnote/blob/90e8dd038da3786f2f6f0a9cfb9d4388da34082d/browser/main/store.js#L259

@yosmoc
Copy link
Member

yosmoc commented May 10, 2018

@yasuokav yes, you are right. need to update storageNoteMap here.

@IssueHuntBot
Copy link

@kazup01 has boosted this issue with $20. Visit this issue on Issuehunt

@Rokt33r
Copy link
Member

Rokt33r commented May 14, 2018

@yosmoc Could you enter the below link, click start work and submit the url of the pull request?
https://issuehunt.io/repos/53266139/issues/1894

Then, we could reward you with $20. :)

@yosmoc
Copy link
Member

yosmoc commented May 14, 2018

@Rokt33r
Thanks, but @yasuokav has almost found the solution when he created the issue. I just confirm his solution and send pull request.

@yasuokav
I suppose you are the right person to get this reward.

@yasuokav
Copy link
Author

@yosmoc Thank you!

@IssueHuntBot
Copy link

@yasuokav has started working. Visit this issue on Issuehunt

@IssueHuntBot
Copy link

@yasuokav has submitted output. Visit this issue on Issuehunt

@IssueHuntBot
Copy link

@kazup01 has rewarded. Visit this issue on Issuehunt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Issue concerns a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants