fix: Support build on Apple Sillicon. #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit added the support to build on Apple Sillicon machine.
Issue:
libclang.dylib is x86_t4 format, The meta_parser failed in linking.
Solution:
For the Apple Siliccon machine, link to the ${OSX_DEVELOPER_ROOT}/Toolchains/XcodeDefault.xctoolchain/usr/lib/libclang.dylib which is universal binary (x86_64 & arm64)
modified: engine/source/meta_parser/CMakeLists.txt
|
谢谢贡献，我们会尽快安排测试 |
|
亲测可行，谢谢大佬 |
Ol6rin
pushed a commit
that referenced
this pull request
Sep 10, 2022
KaygNas
pushed a commit
to KaygNas/Piccolo
that referenced
this pull request
Feb 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit added the support to build on Apple Sillicon machine.
Issue:
libclang.dylib is x86_t4 format, The meta_parser failed in linking.
Solution:
For the Apple Siliccon machine, link to the ${OSX_DEVELOPER_ROOT}/Toolchains/XcodeDefault.xctoolchain/usr/lib/libclang.dylib which is universal binary (x86_64 & arm64)
modified: engine/source/meta_parser/CMakeLists.txt