Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nmodl: update package recipe #2332

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

nmodl: update package recipe #2332

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e3b31fa
nmodl: update package recipe
JCGoran Feb 28, 2024
e00a622
Fix syntax issue
JCGoran Mar 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions bluebrain/repo-bluebrain/packages/nmodl/package.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,8 @@ class Nmodl(CMakePackage):
depends_on("py-pyyaml@3.13:", type=("build", "run"))
depends_on("spdlog")
depends_on("py-find-libpython", type=("run",))
depends_on("py-importlib-resources", type=("run",), when="+python@:3.8")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this really work? Me thinks that should be when="+python ^python@3.8". 3.7 is already EOL!

I'm tempted to say we should just require 3.9+. End of year, that's going to be the minimum supported version anyways.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be when="+python ^python@3.8"

Probably, I read the docs for a whole of 5 seconds beforehand 😅 NMODL doesn't even support 3.7.
Regarding Python 3.9, I have no strong opinions, I don't even have 3.8 on my machine, only 3.9 and later; does anyone actually use NMODL on master, but with Spack and 3.8? I see 3.8 is available on BB5, but have no idea what people use...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BB5 has a default of 3.11

Ubuntu 20.04 has 3.8 by default, but some of our/NSE's software has already moved on. I would drop 3.8 to keep things simple, and maybe just add a

depends_on("python@3.9:")

to formalize that.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(my Spack on Ubuntu 20.04 builds it's own Python 3.10 to avoid conflicts with the system packages, too)

depends_on("py-importlib-metadata", type=("run",), when="+python@:3.8")

def cmake_args(self):
# Do not use the cli11, fmt, pybind11 and spdlog submodule, use the one from
Expand Down
Loading