Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplication in test-code. #868

Closed
1uc opened this issue Nov 27, 2023 · 1 comment
Closed

Remove duplication in test-code. #868

1uc opened this issue Nov 27, 2023 · 1 comment
Labels
testing Anything related to (automated) tests.

Comments

@1uc
Copy link
Collaborator

1uc commented Nov 27, 2023 •
edited
Loading

There's a trait to hide the difference between attributes and datasets. Once:

HighFive/tests/unit/tests_high_five_base.cpp

Line 2078 in acf0fea

struct ReadWriteAttribute {

Twice:

HighFive/tests/unit/tests_high_five_base.cpp

Line 2949 in acf0fea

class ForwardToAttribute {

Place them in a separate header and remove one of the copies.
@1uc 1uc mentioned this issue Dec 18, 2023
Closed
@1uc 1uc added the testing Anything related to (automated) tests. label Jan 30, 2024
@1uc
Copy link
Collaborator Author

1uc commented May 7, 2024

Fixed by #990.

@1uc 1uc closed this as completed May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
testing Anything related to (automated) tests.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@1uc