-
-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Request: Opt ouf of blosc_get_cpu_features
#602
Comments
The workflow originally linked is to cramjam, some python bindings to the Rust bindings (blosc2-rs) There is maybe a more relevant representation of the issue, you can see I have builds for other environment types and the one added here is failing for musl: https://github.com/milesgranger/blosc2-rs/actions/runs/8804935253/job/24166419904?pr=10#step:5:173 Happy to try out any forks/branches if that's helpful, thank you. 👍 |
I'm not the one who contributed that part of the code, but I'll be happy to try your approach. I suggest you to send a PR, let it run in the CI Actions here and see how it goes. Thank you! |
xref: #603 (comment) |
Hello there.
I'm trying to build on musllinux, and also had this issue on x86_64-apple-darwin when statically linking:
full example from workflow: https://github.com/milesgranger/cramjam/actions/runs/8749803819/job/24012143129#step:10:361
It appears this is based off determining
HAVE_CPU_FEAT_INTRIN
here:c-blosc2/blosc/shuffle.c
Line 57 in 7611351
Then will try to get cpu features here:
c-blosc2/blosc/shuffle.c
Line 96 in 7611351
Feature request
I've found if I add an additional logic to opt out, ex "OPT_OUT_CPU_FEAT" to get this function instead, then everything is happy again. But there is also a good chance I'm missing something here. :)
c-blosc2/blosc/shuffle.c
Line 290 in 7611351
The text was updated successfully, but these errors were encountered: