Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deflake YAML specs #24

Closed
Blacksmoke16 opened this issue Aug 6, 2019 · 0 comments · Fixed by #26
Closed

Deflake YAML specs #24

Blacksmoke16 opened this issue Aug 6, 2019 · 0 comments · Fixed by #26
Labels
format:yaml kind:bug An existing feature isn't doing something correctly
Milestone
0.2.1

Comments

@Blacksmoke16
Copy link
Owner

Implement something like https://github.com/crystal-lang/crystal/blob/master/spec/std/yaml/builder_spec.cr#L9-L11 so the specs don't fail if the system's libyaml version doesn't add the ... ending.
@Blacksmoke16 Blacksmoke16 added kind:bug An existing feature isn't doing something correctly format:yaml status:wip labels Aug 6, 2019
@Blacksmoke16 Blacksmoke16 added this to the 0.2.1 milestone Aug 6, 2019
@Blacksmoke16 Blacksmoke16 mentioned this issue Aug 7, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
format:yaml kind:bug An existing feature isn't doing something correctly
Projects
None yet
Milestone
0.2.1
Development

Successfully merging a pull request may close this issue.

Set correct exit code on jq failure Blacksmoke16/oq
1 participant
@Blacksmoke16