fix: Off by one error in next/previous tab #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicholasBoll
commented
Dec 16, 2019
| @@ -23,4 +23,7 @@ | |||
| "autoFix": true | |||
| }, | |||
| ], | |||
| "editor.codeActionsOnSave": { | |||
There was a problem hiding this comment.
The ESLint plugin insisted on this change (added every time I removed it).
NicholasBoll
commented
Dec 16, 2019
|
|
||
| return seq[nextIndex] | ||
| } |
There was a problem hiding this comment.
lint rules prevented an else here
NicholasBoll
commented
Dec 16, 2019
cypress/integration/spec.js
Outdated
| @@ -1,4 +1,5 @@ | |||
| /// <reference types="cypress"/> | |||
| /* global cy */ | |||
There was a problem hiding this comment.
lint-staged forced me to add this.
NicholasBoll
commented
Dec 16, 2019
src/index.js
Outdated
| @@ -1,3 +1,4 @@ | |||
| /* global Cypress, cy */ | |||
There was a problem hiding this comment.
lint-staged forced me to add this
There was a problem hiding this comment.
are you sure you are using local install of eslint? the cypress plugin should have these globals set
|
looks good. I'm going to remove the eslint related changes since I think it's caused by either the cypress plugin not being installed or using global eslint 👍 |
|
🎉 This PR is included in version 1.0.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes the edge cases when using shift-tab when on the first focusable element and the edge case when using tab when on the last focusable element. The error was "Cannot call select of undefined"