Can wslbridge2 return ws_xpixel and ws_ypixel?

[mikoto2000]

The following sections set zero, but some terminals should be able to retrieve pixel-level size.

wslbridge2/src/wslbridge2-backend.cpp

Lines 275 to 276 in 5f444e6

	winsp->ws_xpixel = 0;
	winsp->ws_ypixel = 0;

wslbridge2/src/wslbridge2-backend.cpp

Lines 301 to 303 in 5f444e6

	/* Remove "unused" pixel values ioctl_tty(2) */
	winp.ws_xpixel = 0;
	winp.ws_ypixel = 0;

Is it possible to set these ws_xpixel and ws_ypixel and return them to the app?

[Biswa96]

I am not sure. @mintty may help with terminal related topics.

[mintty]

Mintty provides these values when sending SIGWINCH. I think wslbridge could propagate them along with the cell size, where handling struct winsize. I may find some time occasionally to check but it's a change in wslbridge.

[mikoto2000]

We are setting the value of winp with recv, but can you achieve this by simply deleting the line that overwrites it with zero?

[Biswa96]

Fixed in above PR.

[mintty]

Thanks for taking this patch. Can you make it a release please, for easier integration in wsltty?

[Biswa96]

Released v0.13.

[mintty]

Sorry I didn't test before asking for a release.
But unfortunately, this patch (and thus also 0.13) makes wslbridge2 fail on my systems.
I don't see why this small change would break the backend; maybe a corresponding change in the frontend would also be needed?

[mikoto2000]

@mintty
What exactly does it mean when it breaks?

I rebuilt and run it on Cygwin.(./wslbridge2 --login)

It works, but it seems to be in a state where the prompt is not displayed until several Enter keys are pressed after wslbridge2 starts.

Also, strangely, when I built and ran wslbridge2 v0.12, it terminated with an ERROR: GetVmId:312: CreateLxProcess: NULL 参照ポインターがスタブに渡されました。 error. Maybe my environment is bad.

[mintty]

WSL V1: it hangs, blank terminal window
WSL V2: it terminates, window closes