Code Climate has analyzed commit 080b08b and detected 0 issues on this pull request.

View more on Code Climate.

✔️ Deploy Preview for mobile-wallet-preview ready!

🔨 Explore the source changes: 080b08b

🔍 Inspect the deploy log: https://app.netlify.com/sites/mobile-wallet-preview/deploys/617253ac1eee370007fd0436

😎 Browse the preview: https://deploy-preview-1141--mobile-wallet-preview.netlify.app/

Codecov Report

Merging #1141 (080b08b) into main (356eb52) will increase coverage by 0.12%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1141      +/-   ##
==========================================
+ Coverage   89.07%   89.20%   +0.12%     
==========================================
  Files         195      195              
  Lines        3341     3344       +3     
  Branches      739      740       +1     
==========================================
+ Hits         2976     2983       +7     
+ Misses        363      359       -4     
  Partials        2        2              

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 356eb52...080b08b. Read the comment docs.

Build preview for DeFiChain Wallet is ready!

Built with commit c75550c

https://expo.io/@defichain/wallet?release-channel=pr-preview-1141

Test summary

225 • 0 • 1 • 0

Run details

Project	wallet
Status	Passed
Commit	c75550c ℹ️
Started	Oct 22, 2021 6:04 AM
Ended	Oct 22, 2021 6:12 AM
Duration	08:03 💡
OS	Linux Ubuntu - 20.04
Browser	Chrome 94

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Following the idea of https://github.com/DeFiCh/wallet/blob/main/CONTRIBUTING.md#translation-guides to make translation more discoverable and easy to maintain contextually.

A while back I was trying to create a <Translate> component to make all "Translate-able" components a breeze to write and contextually relevant. I created this but didn't commit it.

import React, { createContext, PropsWithChildren, useContext } from 'react'
import { TranslateOptions } from 'i18n-js'
import { translate } from './index'

interface TranslateProps {
  text: string
  scope?: string
  options?: TranslateOptions
}

const TranslateContext = createContext<string>(undefined as any)

export function Translate (props: TranslateProps): JSX.Element {
  const scope = useContext(TranslateContext)
  return (
    // TODO: add TestId
    <>
      {translate(props.scope ?? scope, props.text, props.options)}
    </>
  )
}

Translate.Context = function (props: PropsWithChildren<{ scope: string }>): JSX.Element {
  return (
    <TranslateContext.Provider value={props.scope}>
      {props.children}
    </TranslateContext.Provider>
  )
}

export function useTranslate (text: string, options?: TranslateOptions): string {
  const scope = useContext(TranslateContext)
  return translate(scope, text, options)
}

This design creates automatically scoped "Translate Context" (aka your screens/context of where it will appear) and a more natural React-based <Translate text='' /> component where explicitly consistent with your node hierarchy.

export function MainView (): JSX.Element {
  function Alert (text: string): void {
    // Do something with text
  }

  return (
    <ThemedView>
      <Translate.Context scope='screens/MainView'>
        <Translate text='Title' />
        <Translate text='Body' />

        <TouchableOpacity onPress={() => {
          Alert(useTranslate('Where I must use `string` text'))
        }}>
          <Translate text='Some Text' scope='screens/AlternativeScope' />
        </TouchableOpacity>
      </Translate.Context>
    </ThemedView>
  )
}

Translation work is then contextually driven:

1. you look at the context you are translating
2. you translate the word within the context
3. contexts are naturally hierarchical
4. they are searchable with the English representation always being the key

Side note: How can we automatically generate the translation mapping? I don't have an answer for that yet.
Mabe running the app in debug mode will automatically index all the translation matrix into JSON file automatically?

Closing this for now, let's re-open another one once we're working on it again