Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

samplenames() to return sample names in order of appearance in genodata #17

Open
pdimens opened this issue Apr 11, 2022 · 0 comments
Open
Labels
bug Something isn't working

Comments

@pdimens
Copy link
Collaborator

pdimens commented Apr 11, 2022

description
currently, samplenames() returns a list of samples in the metadata dataframe, which is not always consistent with the appearance in the genodata. This behavior (for under-the-hood accuracy) needs to be consistent. The genodata df needs to always be sorted by [:name, :locus] and samplenames should return unique(genodata.name). It would probably be best for metadata.sampleinfo to list samplenames in parity with this.

@pdimens pdimens added the bug Something isn't working label Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant